Change the assertion to not to catch the RAR warning #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is intent to catch the warning from Conflict Resolution. Continue investigation on why RAR start to have such warning in dotnet#3508
nguerrera
approved these changes
Aug 5, 2019
|
tell mode email sent |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…ld 20191110.3 (dotnet#3509) - Microsoft.WindowsDesktop.App - 5.0.0-alpha.1.19560.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is intent to catch the warning from Conflict Resolution.
Continue investigation on why RAR start to have such warning in #3508
Description
The test is blocking any SDK PR.
It_tolerates_newline_in_hint_pathis intended to prevent regression of "crash in conflict resolution when hintpath has new line". However, due to a msbuild change, the RAR warning also has the same partial text the test asserts on.Customer Impact
no
Regression?
no
Risk
Low risk.
Test changes in this PR
N/A