Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.0.100-preview8] Update dependencies from dotnet/core-setup #3507

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 5, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/core-setup

  • Build: 20190805.07
  • Date Produced: 8/5/2019 9:13 PM
  • Commit: d01b2fb7bc6bd4911e157fbd51353059a3ba1a6c
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.NET.HostModel -> 3.0.0-preview8-28405-07

…0190805.07

- Microsoft.NET.HostModel - 3.0.0-preview8-28405-07
@wtgodbe
Copy link
Member

wtgodbe commented Aug 6, 2019

Test failure on Windows:

It_tolerates_newline_in_hint_path

The command output contained a result it should not have contained: Illegal characters in path\r\n\r\nFile Name: C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\msbuild.exe\r\nArguments: /t:Build F:\workspace\_work\1\s\artifacts\tmp\Release\SimpleNamesWi---64306239\NETFrameworkLibrary\NETFrameworkLibrary.csproj\r\nExit Code: 0\r\nStdOut:\r\nMicrosoft (R) Build Engine version 16.2.32702+c4012a063 for .NET Framework\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\nBuild started 8/6/2019 1:31:53 AM.\r\nProject "F:\workspace\_work\1\s\artifacts\tmp\Release\SimpleNamesWi---64306239\NETFrameworkLibrary\NETFrameworkLibrary.csproj" on node 1 (Build target(s)).\r\n_CheckForNETCoreSdkIsPreview:\r\n You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview\r\nPrepareForBuild:\r\n Creating directory "bin\Debug\net462\".\r\n Creating directory "obj\Debug\net462\".\r\nResolveAssemblyReferences:\r\n Primary reference "System.Net.Http".\r\nC:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3246: Resolved file has a bad image, no metadata, or is otherwise inaccessible. Illegal characters in path. [F:\workspace\_work\1\s\artifacts\tmp\Release\SimpleNamesWi---64306239\NETFrameworkLibrary\NETFrameworkLibrary.csproj]\r\nGenerateTargetFrameworkMonikerAttribute:\r\nSkipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.\r\nCoreCompile:\r\n C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\Roslyn\csc.exe /noconfig /unsafe- /checked- /nowarn:1701,1702,1701,1702 /nostdlib+ /errorreport:prompt /warn:4 /define:TRACE;DEBUG;NETFRAMEWORK;NET462 /highentropyva+ /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Data.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Drawing.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.IO.Compression.FileSystem.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Numerics.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Runtime.Serialization.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Xml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.2\System.Xml.Linq.dll" /debug+ /debug:portable /filealign:512 /optimize- /out:obj\Debug\net462\NETFrameworkLibrary.dll /ruleset:"C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\Team Tools\Static Analysis Tools\\Rule Sets\MinimumRecommendedRules.ruleset" /subsystemversion:6.00 /target:library /warnaserror- /utf8output /deterministic+ NETFrameworkLibrary.cs "C:\Users\vsagent\AppData\Local\Temp\.NETFramework,Version=v4.6.2.AssemblyAttributes.cs" obj\Debug\net462\NETFrameworkLibrary.AssemblyInfo.cs /warnaserror+:NU1605\r\n Using shared compilation with compiler from directory: C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\Roslyn\r\nCopyFilesToOutputDirectory:\r\n Copying file from "F:\workspace\_work\1\s\artifacts\tmp\Release\SimpleNamesWi---64306239\NETF

Maybe related to dotnet/corefx#39981? CC @davidsh @livarcocc

@wtgodbe
Copy link
Member

wtgodbe commented Aug 6, 2019

Failure is consistent, and seems unlikely to be related to dotnet/core-setup#7549 (which was the only other change that this PR is ingesting)

@wtgodbe
Copy link
Member

wtgodbe commented Aug 6, 2019

Also CC @dsplaisted, @nguerrera in case Livar is still in training

@davidsh
Copy link

davidsh commented Aug 6, 2019

Maybe related to dotnet/corefx#39981? CC @davidsh @livarcocc

I don't see how it can be related. The changes are small. What file would have illegal characters in it? PR dotnet/corefx#39981 only changed 2 files:

  • src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs
  • src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs

@nguerrera
Copy link
Contributor

nguerrera commented Aug 6, 2019

We would need to cherry pick #3509

The version of full framework msbuild (VS) on the build machines changed and caught a test defect. I am going to merge this as it is a known test defect and everything else is green. I don't think it's worth waiting on another CI run. If another update comes through, cherry pick #3509 onto it.

@nguerrera nguerrera merged commit 7c9956b into release/3.0.100-preview8 Aug 6, 2019
@nguerrera nguerrera deleted the darc-release/3.0.100-preview8-afb5e21d-13a7-49e7-b04b-4134fc8dfe72 branch August 6, 2019 04:05
livarcocc added a commit to livarcocc/sdk that referenced this pull request Aug 13, 2019
…eview8_into_release/3.0.1xx

* release/3.0.100-preview8:
  Update dependencies from https://github.com/dotnet/core-setup build 20190805.07 (dotnet#3507)
  Insert NuGet Build 5.3.0-preview.2.6136 into sdk (dotnet#3494)
  [release/3.0.100-preview8] Update dependencies from dotnet/core-setup (dotnet#3491)
  Update dependencies from https://github.com/dotnet/core-setup build 20190729.14 (dotnet#3483)

Conflicts:
eng/Version.Details.xml
eng/Versions.props
livarcocc added a commit to livarcocc/sdk that referenced this pull request Aug 13, 2019
…eview8_into_release/3.0.1xx

* release/3.0.100-preview8:
  Update dependencies from https://github.com/dotnet/core-setup build 20190805.07 (dotnet#3507)
  Insert NuGet Build 5.3.0-preview.2.6136 into sdk (dotnet#3494)
  [release/3.0.100-preview8] Update dependencies from dotnet/core-setup (dotnet#3491)
  Update dependencies from https://github.com/dotnet/core-setup build 20190729.14 (dotnet#3483)

Conflicts:
eng/Version.Details.xml
eng/Versions.props
global.json
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
* Update dependencies from https://github.com/dotnet/core-setup build 20191109.5

- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.19559.5
- Microsoft.NET.HostModel - 5.0.0-alpha.1.19559.5
- Microsoft.Extensions.DependencyModel - 5.0.0-alpha.1.19559.5
- Microsoft.DotNet.PlatformAbstractions - 5.0.0-alpha.1.19559.5
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.19559.5
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.19559.5

* Update dependencies from https://github.com/dotnet/core-setup build 20191111.10

- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.19561.10
- Microsoft.NET.HostModel - 5.0.0-alpha.1.19561.10
- Microsoft.Extensions.DependencyModel - 5.0.0-alpha.1.19561.10
- Microsoft.DotNet.PlatformAbstractions - 5.0.0-alpha.1.19561.10
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.19561.10
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.19561.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants