This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] Stop signing apphost.exe and comhost.dll in AppHost pack nupkg #7549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ericstj
approved these changes
Aug 2, 2019
AaronRobinsonMSFT
approved these changes
Aug 2, 2019
elinor-fung
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures the
apphost.exeandcomhost.dlltemplates aren't signed. The Arcade migration unintentionally caused them to be signed in the NuGet package artifacts. These are used to assemble the 3.0 SDK, and they're pushed to the NuGet gallery to allow later SDKs (e.g. 5.0) to acquire the artifacts needed to build apps for earlier runtimes (3.0).Customer Impact
https://github.com/dotnet/core-setup/issues/7550
error: 0x800700C1Regression?
Yes, this is a regression from 3.0 preview 7 to 3.0 preview 8.
Risk
Minimal. This signing tool configuration setting is supported by Arcade.
/cc @JohnTortugo
(cherry picked from commit 0245522) (#7547)
(cherry picked from commit 18e5616) (#7548, typo fixup)