Update VPN user agent #3302
Merged
Update VPN user agent #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Sep 2, 2024
PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift
Show resolved
Hide resolved
# By Lucas Adamski (1) and amddg44 (1) # Via GitHub * main: Sync promotions added to Bookmarks & Passwords screens (#3260) remove references to obsolete FBConfig (#3297) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
6 tasks
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# By Christopher Brind (4) and others # Via Alessandro Boron (1) and others * main: (27 commits) Bump C-S-S to 6.14.1 (#3331) DuckPlayer Launch Experiment for iOS (#3328) defer loading the tab switcher button until view did load (#3326) Release 7.136.0-3 (#3324) Release PR: Check for the negative attribution case (#3311) fix tab switcher crashes (speculative fix) (#3319) Onboarding highlights feature flag setup (#3308) Release 7.136.0-2 (#3320) Attempt to fix dissapearing privacy icon (#3317) Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313) Bump BSK with C-S-S to 6.14.0 (#3314) ensure no atb or app version sent with pixel (#3315) Fix #3298: Add support for Xcode 16 (#3299) Fix Keychain Debug view controller segue (#3310) Release 7.136.0-1 (#3309) Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305) [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290) usage segmentation (#3263) Fix wrong URL displayed for auth dialog (#3307) iOS Integration of BSK Onboarding (#3282) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
requested review from
quanganhdo
and removed request for
quanganhdo
quanganhdo
approved these changes
Sep 9, 2024
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 9, 2024
Required: Task/Issue URL: https://app.asana.com/0/1207162258152427/1207484485195971/f iOS PR: duckduckgo/iOS#3302 macOS PR: duckduckgo/macos-browser#3181 What kind of version bump will this require?: Patch Description: This PR updates the VPN client to read from APIRequest.Headers when setting up requests. Later, the client class should be refactored to use APIRequest across the board for increased testability, but for now I'm reusing a pattern used in a number of places in the clients.
# By Alessandro Boron (2) and others # Via GitHub * main: Duckplayer Experiment Override Fix (#3329) New feature flag for autofillSurveys (#3318) Add Onboarding Progress bar (#3323) Add copy for onboarding highlights experiment (#3325) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207162258152427/1207484485195971/f
Tech Design URL:
CC:
Description:
This PR updates the user agent of the VPN to include the version number, not just build number.
Steps to test this PR:
Logger.networkProtection.error("Registering with VPN using headers \(String(describing: request.allHTTPHeaderFields), privacy: .public)")Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template