Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Log Driver] Change hosts config flag #23628

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jan 21, 2021

What does this PR do?

When we switched over the CLI for the Elastic Log Driver a while ago, it looks like we missed a few sections of documentation. We need to update that now.

Why is it important?

Docs are incorrect.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry requested review from dedemorton and a team January 21, 2021 20:26
@fearful-symmetry fearful-symmetry self-assigned this Jan 21, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2021
@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23628 updated

    • Start Time: 2021-01-21T20:41:28.603+0000
  • Duration: 30 min 44 sec

  • Commit: 7f8442c

❕ Flaky test report

No test was executed to be analysed.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry fearful-symmetry merged commit 72880ca into elastic:master Jan 25, 2021
v1v added a commit to v1v/beats that referenced this pull request Jan 26, 2021
…pack-when-oss-changes

* upstream/master:
  [DOCS] Add setup content to Kubernetes and Cloud Foundry docs (elastic#23580)
  [CI] Mandatory windows support for all the versions (elastic#23615)
  Add check when retrieving the worker process id using performance counters  (elastic#23647)
  Remove 4912 evtx from testing (elastic#23669)
  Add missing SSL settings (elastic#23632)
  Update X-Pack Packetbeat config (elastic#23666)
  Use hostname check from verify.go to handle patterns in TLS certs (elastic#23661)
  Fix: Dissect Cisco ASA 302013 message usernames (elastic#21196)
  Add FAQ entry for MADV settings in older versions (elastic#23429)
  Sync fixes from Integration Package Testing (elastic#23424)
  [Filebeat] Add Cisco ASA message '302023' parsing (elastic#23092)
  [Elastic Log Driver] Change hosts config flag (elastic#23628)
  Audit and Authentication Policy Change Events (elastic#20684)
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Feb 10, 2021
* change hosts config flag

* add changelog now

(cherry picked from commit 72880ca)
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Feb 10, 2021
* change hosts config flag

* add changelog now

(cherry picked from commit 72880ca)
fearful-symmetry added a commit that referenced this pull request Feb 10, 2021
* change hosts config flag

* add changelog now

(cherry picked from commit 72880ca)
fearful-symmetry added a commit that referenced this pull request Feb 10, 2021
* change hosts config flag

* add changelog now

(cherry picked from commit 72880ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants