Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter is called "hosts" and not "endpoint" #23644

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

DracoBlue
Copy link
Contributor

See

endpoint, ok := input["hosts"]
for reference

What does this PR do?

Fixes the documentation stating endpoint as parameter, even though it must be hosts.

Why is it important?

Otherwise it's missleading and people are confused.

Checklist

  • I have made corresponding changes to the documentation

How to test this PR locally

Check the docs in readme.md

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23644 updated

    • Start Time: 2021-02-06T00:18:42.738+0000
  • Duration: 19 min 44 sec

  • Commit: 536584c

❕ Flaky test report

No test was executed to be analysed.

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Jan 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2021
@fearful-symmetry
Copy link
Contributor

This was fixed here a few days ago: #23628

@fearful-symmetry
Copy link
Contributor

However, looks like that change never made it to the actual readme.md file.

@fearful-symmetry
Copy link
Contributor

jenkins, test this

@fearful-symmetry
Copy link
Contributor

/test

@fearful-symmetry
Copy link
Contributor

Sorry, @DracoBlue , can you add an entry to CHANGELOG.next ?

@DracoBlue
Copy link
Contributor Author

Sorry, @DracoBlue , can you add an entry to CHANGELOG.next ?

Done!

@fearful-symmetry fearful-symmetry merged commit 2363df4 into elastic:master Feb 8, 2021
@DracoBlue DracoBlue deleted the patch-1 branch March 1, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants