Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component-development.md #5028

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Update component-development.md #5028

merged 1 commit into from
Aug 13, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 13, 2021

Summary

Remove FORCE_DLL_CREATION=true of the component development documentation, since it's no longer needed. When combining Kibana and a EUI branch, dlls are no longer created since elastic/kibana#72096

Tested it in a cloud deployment, works.

Remove FORCE_DLL_CREATION=true since it's no longer needed
@kertal kertal added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Aug 13, 2021
@kertal kertal self-assigned this Aug 13, 2021
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5028/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kertal!

@thompsongl thompsongl merged commit 1b12d1d into master Aug 13, 2021
@thompsongl thompsongl deleted the kertal-doc-patch-1 branch November 1, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants