Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): teardown dynamic dll plugin #72096

Merged
merged 10 commits into from
Jul 17, 2020
Merged

chore(NA): teardown dynamic dll plugin #72096

merged 10 commits into from
Jul 17, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Jul 16, 2020 •
edited
Loading

That PR removes the DynamicDllPlugin and all the logic associated with it. After #72017 being merged there is no more node_modules being processed by the legacy optimizer so we can just remove the usage of that plugin.

When we built that plugin more than 2 years ago we did it because we reached a point were we could not live anymore without such a tool. I'm very glad to realise that we did such a long way since then into a point we don't need it anymore!

/cc @elastic/kibana-platform

@mistic mistic added chore Team:Operations Team label for Operations Team build v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 16, 2020
@mistic mistic requested review from a team as code owners July 16, 2020 16:17
@mistic mistic self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

pgayvallet
pgayvallet approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restrry already approved, but for posterity's sake.

@tylersmalley
Copy link
Contributor

Can this be removed as well? https://github.com/elastic/kibana/blob/master/packages/kbn-pm/src/config.ts#L34-L45

@tylersmalley
Copy link
Contributor

This section can be removed from the build docs: https://github.com/elastic/kibana/blob/master/src/dev/build/README.md#client-node-modules-cleaning

@tylersmalley
Copy link
Contributor

One more reference to FORCE_DLL_CREATION https://github.com/elastic/kibana/blob/master/src/dev/build/tasks/optimize_task.js#L44

@mistic
Copy link
Member Author

mistic commented Jul 16, 2020

@tylersmalley it probably could but I haven't due to a explanation I also have on that text -> In anyway, have a plugin declaring their own dependencies is the correct and the expect behavior. In the current POC I'm doing with bazel having those plugins expressing their dependencies was very useful to build the single package.json. I think we should keep it.

@mistic
Copy link
Member Author

mistic commented Jul 16, 2020

@tylersmalley I've removed all the additional mentions to the DLL work that you've found! Thanks!!

@tylersmalley
Copy link
Contributor

tylersmalley commented Jul 16, 2020 •
edited
Loading

The DLL work being removed here was a huge improvement at the time to the developer experience and production optimization. As a reminder, production optimize time was almost 5 minutes and this cut it in half. In the end, it bought us a ton of time to get to where we are at today. 🙇 @mistic

@mistic mistic added v7.10.0 and removed v7.10.0 labels Jul 16, 2020
@mistic mistic requested a review from a team as a code owner July 16, 2020 19:50
@spalger spalger removed the request for review from a team July 16, 2020 19:53
@spalger
Copy link
Contributor

spalger commented Jul 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jul 17, 2020

@spalger Thank you for your help!

@mistic mistic merged commit 9296369 into elastic:master Jul 17, 2020
@mistic mistic mentioned this pull request Jul 17, 2020
Merged
mistic added a commit to mistic/kibana that referenced this pull request Jul 17, 2020
@mistic
chore(NA): teardown dynamic dll plugin (elastic#72096)
a572c33 
* chore(NA): teardown dynamic dll plugin

* chore(NA): remove missing ts-ignore

* chore(NA): remove last mentions to the DLL machinery

* chore(NA): update notice file

* prevent duplication and searching target/public

* remove changes to es-ui code to unblock pr

* add node internals override for legacy tests bundle

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/dev/notice/generate_notice_from_source.ts
#	src/optimize/base_optimizer.js
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
edb3f1e 
* master: (214 commits)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  [Monitoring] Out of the box alert tweaks (elastic#71942)
  [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
cbee849 
* master: (55 commits)
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  ...
mistic added a commit that referenced this pull request Jul 17, 2020
@mistic
chore(NA): teardown dynamic dll plugin (#72096) (#72248)
ce91760 
* chore(NA): teardown dynamic dll plugin

* chore(NA): remove missing ts-ignore

* chore(NA): remove last mentions to the DLL machinery

* chore(NA): update notice file

* prevent duplication and searching target/public

* remove changes to es-ui code to unblock pr

* add node internals override for legacy tests bundle

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/dev/notice/generate_notice_from_source.ts
#	src/optimize/base_optimizer.js
@mistic
Copy link
Member Author

mistic commented Jul 17, 2020

7.x: ce91760

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
fead80a 
…feature-privileges

* alerting/consumer-based-rbac: (56 commits)
  take into account which features available in the active space
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  ...
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020
@mistic @spalger
@elasticmachine @chrisronline
chore(NA): teardown dynamic dll plugin (elastic#72096)
958dd19 
* chore(NA): teardown dynamic dll plugin

* chore(NA): remove missing ts-ignore

* chore(NA): remove last mentions to the DLL machinery

* chore(NA): update notice file

* prevent duplication and searching target/public

* remove changes to es-ui code to unblock pr

* add node internals override for legacy tests bundle

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@pgayvallet pgayvallet mentioned this pull request Jul 20, 2020
Merged
2 tasks
@kertal kertal mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger left review comments

@tylersmalley tylersmalley tylersmalley approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@mshustov mshustov mshustov approved these changes

Assignees

@mistic mistic

Labels
build chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mistic @elasticmachine @tylersmalley @spalger @kibanamachine @pgayvallet @mshustov