Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Out of the box alert tweaks #71942

Merged
merged 5 commits into from
Jul 16, 2020

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Jul 15, 2020

Resolves #71918
Resolves #71920
Resolves #72116

@chrisronline chrisronline self-assigned this Jul 16, 2020
@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 16, 2020
@chrisronline chrisronline marked this pull request as ready for review July 16, 2020 14:47
@chrisronline chrisronline requested a review from a team July 16, 2020 14:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
monitoring 1.2MB +25.0B 1.2MB

page load bundle size

id value diff baseline
monitoring 296.4KB +512.0B 295.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I checked all the cases, everything looks good 👍

Thanks for the quick fixes 🥇

@chrisronline chrisronline merged commit 28189c2 into elastic:master Jul 16, 2020
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 16, 2020
* Tweaks to thresholds and throttle periods

* Fixes

* Type fix, and more defensive against no alerts

* Remove unnecessary restrictions
chrisronline added a commit that referenced this pull request Jul 16, 2020
* Tweaks to thresholds and throttle periods

* Fixes

* Type fix, and more defensive against no alerts

* Remove unnecessary restrictions
chrisronline added a commit that referenced this pull request Jul 16, 2020
* Tweaks to thresholds and throttle periods

* Fixes

* Type fix, and more defensive against no alerts

* Remove unnecessary restrictions
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
* master: (214 commits)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  [Monitoring] Out of the box alert tweaks (elastic#71942)
  [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976)
  ...
@chrisronline
Copy link
Contributor Author

Backport:

7.9: 7401c61
7.x: 2a09127

@chrisronline chrisronline deleted the monitoring/oob_alert_fixes branch July 20, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.9.0 v8.0.0
Projects
None yet
4 participants