Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solutions] Replaces most deprecated io-ts alerting and list types (#100234) #100246

Merged
merged 1 commit into from
May 18, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

… types (elastic#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 195 194 -1
securitySolution 2116 2106 -10
total -11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lists 210 207 -3
securitySolution 50 32 -18
total -21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 55.2KB 55.2KB -21.0B
securitySolution 6.7MB 6.8MB +89.3KB
total +89.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 190.1KB 188.8KB -1.3KB
securitySolution 159.7KB 61.1KB -98.5KB
total -99.9KB
Unknown metric groups

API count

id before after diff
lists 232 229 -3
securitySolution 59 32 -27
total -30

References to deprecated APIs

id before after diff
monitoring 109 56 -53

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@kibanamachine kibanamachine merged commit 18e6085 into elastic:7.x May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants