Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] (Phase 2) Adds deprecation to all the io-ts types and copies of them #99260

Merged
merged 1 commit into from
May 4, 2021
Merged

[Security Solutions] (Phase 2) Adds deprecation to all the io-ts types and copies of them #99260

merged 1 commit into from
May 4, 2021

Conversation

FrankHassanabad
Copy link
Contributor

Summary

Adds deprecation to all the io-ts types and copies of them found in the code base.

Phase 1 (Completed): Copy all the utilities to the packages/kbn-securitysolution-io-ts-utils
Phase 2: Add all the deprecation messages about them to the code base
Phase 3+: Teams and others will eventually remove/replace them with the utils from kbn-securitysolution-io-ts-utils

@FrankHassanabad FrankHassanabad requested review from a team as code owners May 4, 2021 20:41
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@FrankHassanabad FrankHassanabad self-assigned this May 4, 2021
@FrankHassanabad FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed Team:Detections and Resp Security Detection Response Team labels May 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

dominiqueclarke
dominiqueclarke approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine on the Uptime side.

lykkin
lykkin approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@lykkin lykkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the asset management side!

spong
spong approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 2 LGTM from Security Solution 👍.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / "before all" hook for "should contain notes".Timeline notes tab "before all" hook for "should contain notes"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `.euiBadge`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Timeline notes tab`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/notes_tab.spec.ts:15934:14)

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit 92da105 into elastic:master May 4, 2021
@FrankHassanabad FrankHassanabad deleted the deprecate branch May 4, 2021 23:00
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2021
@FrankHassanabad @kibanamachine
Added deprecation to all the io-ts types and copies of them (elastic#…
cb2e7db 
…99260)

## Summary

Adds deprecation to all the io-ts types and copies of them found in the code base.

Phase 1 (Completed): Copy all the utilities to the `packages/kbn-securitysolution-io-ts-utils`
Phase 2: Add all the deprecation messages about them to the code base
Phase 3+: Teams and others will eventually remove/replace them with the utils from `kbn-securitysolution-io-ts-utils`
@kibanamachine kibanamachine mentioned this pull request May 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 5, 2021
@kibanamachine @FrankHassanabad
Added deprecation to all the io-ts types and copies of them (#99260) (#…
2a1f977 
…99289)

## Summary

Adds deprecation to all the io-ts types and copies of them found in the code base.

Phase 1 (Completed): Copy all the utilities to the `packages/kbn-securitysolution-io-ts-utils`
Phase 2: Add all the deprecation messages about them to the code base
Phase 3+: Teams and others will eventually remove/replace them with the utils from `kbn-securitysolution-io-ts-utils`

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
@FrankHassanabad FrankHassanabad mentioned this pull request May 17, 2021
Merged
1 task
FrankHassanabad added a commit that referenced this pull request May 18, 2021
@FrankHassanabad
[Security Solutions] Replaces most deprecated io-ts alerting and list…
e15b887 
… types (#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as #99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 18, 2021
@FrankHassanabad @kibanamachine
[Security Solutions] Replaces most deprecated io-ts alerting and list…
810f097 
… types (elastic#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this pull request May 18, 2021
@kibanamachine @FrankHassanabad
[Security Solutions] Replaces most deprecated io-ts alerting and list…
18e6085 
… types (#100234) (#100246)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as #99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@FrankHassanabad @yctercero
[Security Solutions] Replaces most deprecated io-ts alerting and list…
2d09e26 
… types (elastic#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@peluja1012 peluja1012 mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lykkin lykkin lykkin approved these changes

@spong spong spong approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FrankHassanabad @elasticmachine @kibanamachine @lykkin @spong @dominiqueclarke