ping Core team when renovate bot bumps es client version #100662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mshustov
added
backport:skip
joshdover
approved these changes
May 26, 2021
mshustov
commented
May 26, 2021
| @@ -44,17 +44,17 @@ | |||
| { | |||
| groupName: '@elastic/elasticsearch', | |||
| packageNames: ['@elastic/elasticsearch'], | |||
| reviewers: ['team:kibana-operations'], | |||
| reviewers: ['team:kibana-operations', 'team:kibana-core'], | |||
There was a problem hiding this comment.
@elastic/kibana-operations What is the correct format? I'd expect it to be @elastic/kibana-operations and @elastic/kibana-core respectively
There was a problem hiding this comment.
https://docs.renovatebot.com/configuration-options/#reviewers
Must be valid usernames. If on GitHub and assigning a team to review, use the prefix team:, e.g. provide a value like team:someteam.
LGTM
This reverts commit fc8ac97.
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 26, 2021
* master: (60 commits) [Docs] Index patterns REST API docs (elastic#100549) [Ingest pipelines] add support for fingerprint processor (elastic#100541) ping Core team when renovate bot bumps es client version (elastic#100662) [Maps] Add draw wizard (elastic#100278) Use documentation link service for index pattern field editor (elastic#100609) [Maps] filter dashboard by map extent (elastic#99860) [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514) fix anomaly functional test (elastic#100504) update breaking changes template to incorporate ES deprecations (elastic#100621) improve default time ranges (elastic#100536) [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535) [ftr] migrate "globalNav" service to FtrService class (elastic#100604) [ftr] migrate "testSubjects" to FtrService class (elastic#100512) Fix spaces test flakyness (elastic#100605) [Ingest pipelines] add support for ip type in convert processor (elastic#100531) [ftr] migrate "browser" to FtrService class (elastic#100507) [ftr] migrate "find" service to FtrService class (elastic#100509) [telemetry] report config deprecations (elastic#99887) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) ...
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
) * ping Core team on es client version upgrade * use @elastic/kibana-core * Revert "use @elastic/kibana-core" This reverts commit fc8ac97.
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
) * ping Core team on es client version upgrade * use @elastic/kibana-core * Revert "use @elastic/kibana-core" This reverts commit fc8ac97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.