[Maps] filter dashboard by map extent #99860

nreese · 2021-05-11T22:30:01Z

This PR adds a new context menu option for map embeddables.

When selected, a filter will be added to the dashboard that filters all panels by the map view area. When the map moves, this filter will be updated for the new map extent

cc @mbarretta

elasticmachine · 2021-05-11T22:30:04Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2021-05-12T14:09:49Z

src/plugins/data/public/ui/filter_bar/filter_item.tsx

@@ -286,6 +286,11 @@ export function FilterItem(props: FilterItemProps) {
      message: '',
      status: FILTER_ITEM_OK,
    };
+
+    if (filter.meta?.isMultiIndex) {


@Dosant @lizozom isMultiIndex flag was added to remove "Warning" label from the filter pill

The screen shot below was taken before these changes. Notice the "Warning" label. In this case, its not warranted since the filter is written to target any index pattern in the dashboard

This is a screen shot after the changes. Notice that the warning label is gone

jsanz · 2021-05-12T17:19:52Z

@nreese I'm testing this (Chromium and Firefox browsers on Linux) and I don't get the filter updated when I move the map. I don't see any errors on the console either. Anything I can check or test to be sure I'm doing it right?

nreese · 2021-05-12T17:38:58Z

I'm testing this (Chromium and Firefox browsers on Linux) and I don't get the filter updated when I move the map. I don't see any errors on the console either. Anything I can check or test to be sure I'm doing it right?

It looks like you are doing everything correctly but there is something weird. Each time you got to the panel menu, the text says "filter by map extent". When filterByMapExtent is enabled, it should read "disable filter by map extent". So it looks like some state is not getting preserved in your instance.

nreese · 2021-05-12T17:59:35Z

@jsanz You have to put the dashboard in edit mode to enable filter by map bounds. Not being in edit mode unsets the value after it was set. I will merge a fix to remove the option when not in edit mode

nreese · 2021-05-12T18:10:09Z

@jsanz I have pushed a fix so you can not toggle filtering by extent while outside of dashboard edit mode. Mind pulling the latest and re-testing?

jsanz · 2021-05-13T11:41:00Z

Thanks, @nreese now it works as expected. It's a pity that this only works in dashboard edit mode, but nevertheless a very powerful feature.

nreese · 2021-05-13T15:57:26Z

@elasticmachine merge upstream

nreese · 2021-05-24T12:29:25Z

@elasticmachine merge upstream

thomasneirynck

Thanks a lot, this is a great PR.

x-pack/plugins/maps/public/trigger_actions/filter_by_map_extent_action.ts

thomasneirynck · 2021-05-24T15:23:27Z

x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.ts

+              return {
+                bool: {
+                  must: [
+                    {


x-pack/plugins/maps/public/embeddable/map_embeddable.tsx

src/plugins/data/public/actions/apply_filter_action.ts

x-pack/plugins/maps/public/embeddable/types.ts

x-pack/plugins/maps/public/embeddable/map_embeddable.tsx

nreese · 2021-05-25T15:31:44Z

@elasticmachine merge upstream

kibanamachine · 2021-05-25T18:51:18Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	782	783	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	3263	3264	+1
`maps`	191	195	+4
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`data`	165.3KB	165.4KB	+121.0B
`maps`	2.7MB	2.7MB	+3.3KB
total			+3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	817.4KB	817.5KB	+162.0B
`maps`	62.2KB	63.2KB	+984.0B
total			+1.1KB

Unknown metric groups

API count

id	before	after	diff
`data`	3763	3764	+1
`maps`	192	196	+4
total			+5

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	261	149	-112
`lens`	67	45	-22
`licensing`	18	15	-3
`lists`	239	236	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`securitySolution`	386	342	-44
`stackAlerts`	101	95	-6
total			-342

History

💚 Build #127158 succeeded 409eb0b
💚 Build #126928 succeeded 3bafeb5
💚 Build #126870 succeeded 970d259
💛 Build #125813 was flaky 3002fa7
💚 Build #125677 succeeded a210fef

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar

app services changes LGTM

ppisljar · 2021-05-26T12:34:10Z

reposting comment from above for visibility:

nit: would it make sense to rename this to id to make it more general ? it seems it kind of needs to be unique anyway and controlledBy might not be the best name as possibly multiple filters are controlled by a single consumer (and they would all need different controlledBy id even if they are controlled by the same thing)

* [Maps] filter dashboard by map extent * clean up * remove warning from filter pill * tslint * API doc updates, i18n fixes, tslint * only show context menu option in edit mode * add functional test * review feedback * do not use search session when filtering by map bounds Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-05-26T14:53:59Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* master: (60 commits) [Docs] Index patterns REST API docs (elastic#100549) [Ingest pipelines] add support for fingerprint processor (elastic#100541) ping Core team when renovate bot bumps es client version (elastic#100662) [Maps] Add draw wizard (elastic#100278) Use documentation link service for index pattern field editor (elastic#100609) [Maps] filter dashboard by map extent (elastic#99860) [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514) fix anomaly functional test (elastic#100504) update breaking changes template to incorporate ES deprecations (elastic#100621) improve default time ranges (elastic#100536) [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535) [ftr] migrate "globalNav" service to FtrService class (elastic#100604) [ftr] migrate "testSubjects" to FtrService class (elastic#100512) Fix spaces test flakyness (elastic#100605) [Ingest pipelines] add support for ip type in convert processor (elastic#100531) [ftr] migrate "browser" to FtrService class (elastic#100507) [ftr] migrate "find" service to FtrService class (elastic#100509) [telemetry] report config deprecations (elastic#99887) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) ...

* [Maps] filter dashboard by map extent * clean up * remove warning from filter pill * tslint * API doc updates, i18n fixes, tslint * only show context menu option in edit mode * add functional test * review feedback * do not use search session when filtering by map bounds Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

* [Maps] filter dashboard by map extent * clean up * remove warning from filter pill * tslint * API doc updates, i18n fixes, tslint * only show context menu option in edit mode * add functional test * review feedback * do not use search session when filtering by map bounds Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Maps] filter dashboard by map extent

73c32df

nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.14.0 reason:enhancement labels May 11, 2021

nreese requested a review from thomasneirynck May 11, 2021 22:30

nreese requested a review from a team as a code owner May 11, 2021 22:30

nreese added release_note:enhancement and removed reason:enhancement labels May 11, 2021

nreese added 2 commits May 11, 2021 16:33

clean up

8e3133a

remove warning from filter pill

52d6025

nreese commented May 12, 2021

View reviewed changes

nreese added 2 commits May 12, 2021 08:20

tslint

f6d1aa8

API doc updates, i18n fixes, tslint

1ce2938

only show context menu option in edit mode

585a49a

add functional test

a210fef

nreese requested a review from a team as a code owner May 12, 2021 19:14

Merge branch 'master' into issue_59751

3002fa7

Merge branch 'master' into issue_59751

970d259

thomasneirynck approved these changes May 24, 2021

View reviewed changes

ppisljar reviewed May 24, 2021

View reviewed changes

x-pack/plugins/maps/public/embeddable/types.ts Show resolved Hide resolved

ppisljar reviewed May 24, 2021

View reviewed changes

x-pack/plugins/maps/public/embeddable/map_embeddable.tsx Show resolved Hide resolved

nreese requested a review from ppisljar May 24, 2021 17:37

review feedback

3bafeb5

kibanamachine and others added 2 commits May 25, 2021 11:31

Merge branch 'master' into issue_59751

409eb0b

do not use search session when filtering by map bounds

fe8cbb8

ppisljar approved these changes May 26, 2021

View reviewed changes

nreese mentioned this pull request May 26, 2021

Feature fix 99239 #99482

Closed

8 tasks

nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label May 26, 2021

nreese merged commit e49db71 into elastic:master May 26, 2021

kibanamachine mentioned this pull request May 26, 2021

[7.x] [Maps] filter dashboard by map extent (#99860) #100690

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] filter dashboard by map extent #99860

[Maps] filter dashboard by map extent #99860

nreese commented May 11, 2021

elasticmachine commented May 11, 2021

nreese May 12, 2021

jsanz commented May 12, 2021

nreese commented May 12, 2021

nreese commented May 12, 2021 •

edited

Loading

nreese commented May 12, 2021

jsanz commented May 13, 2021

nreese commented May 13, 2021

nreese commented May 24, 2021

thomasneirynck left a comment

thomasneirynck May 24, 2021

nreese commented May 25, 2021

kibanamachine commented May 25, 2021

API count

References to deprecated APIs

ppisljar left a comment

ppisljar commented May 26, 2021

kibanamachine commented May 26, 2021

[Maps] filter dashboard by map extent #99860

[Maps] filter dashboard by map extent #99860

Conversation

nreese commented May 11, 2021

elasticmachine commented May 11, 2021

nreese May 12, 2021

Choose a reason for hiding this comment

jsanz commented May 12, 2021

nreese commented May 12, 2021

nreese commented May 12, 2021 • edited Loading

nreese commented May 12, 2021

jsanz commented May 13, 2021

nreese commented May 13, 2021

nreese commented May 24, 2021

thomasneirynck left a comment

Choose a reason for hiding this comment

thomasneirynck May 24, 2021

Choose a reason for hiding this comment

nreese commented May 25, 2021

kibanamachine commented May 25, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

History

ppisljar left a comment

Choose a reason for hiding this comment

ppisljar commented May 26, 2021

kibanamachine commented May 26, 2021

💚 Backport successful

nreese commented May 12, 2021 •

edited

Loading