Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] update text for Isolation action submissions #105956

Merged
merged 8 commits into from
Jul 19, 2021
Merged

[Security Solution] update text for Isolation action submissions #105956

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cebf161
[Security Solution] update text for Isolation action submissions
kevinlog Jul 16, 2021
377174f
fix tests
kevinlog Jul 16, 2021
fedc3c4
Merge branch 'master' into task/update-isolate-action-text
kibanamachine Jul 19, 2021
9de870b
update text per product feedback
kevinlog Jul 19, 2021
60114aa
text feedback
kevinlog Jul 19, 2021
b35170a
update test
kevinlog Jul 19, 2021
a66eea2
update text
kevinlog Jul 19, 2021
e7588ca
Merge branch 'task/update-isolate-action-text' of github.com:kevinlog…
kevinlog Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/cases/public/components/user_action_tree/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ export const UNKNOWN_RULE = i18n.translate('xpack.cases.caseView.unknownRule.lab
});

export const ISOLATED_HOST = i18n.translate('xpack.cases.caseView.isolatedHost', {
defaultMessage: 'isolated host',
defaultMessage: 'isolate submitted on host',
});

export const RELEASED_HOST = i18n.translate('xpack.cases.caseView.releasedHost', {
defaultMessage: 'released host',
defaultMessage: 'release submitted on host',
});

export const OTHER_ENDPOINTS = (endpoints: number): string =>
Expand Down
2 changes: 1 addition & 1 deletion ...ases/public/components/user_action_tree/user_action_host_isolation_comment_event.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('UserActionHostIsolationCommentEvent', () => {
it('renders with the correct action and hostname', async () => {
const wrapper = mount(<HostIsolationCommentEvent {...defaultProps()} />);
expect(wrapper.find(`[data-test-subj="actions-link-e1"]`).first().exists()).toBeTruthy();
expect(wrapper.text()).toBe('isolated host host1');
expect(wrapper.text()).toBe('isolate submitted on host host1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Using ISOLATED_HOST variable would be better to avoid change texts in tests.

});

it('navigates to app on link click', async () => {
Expand Down
12 changes: 6 additions & 6 deletions x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,39 +54,39 @@ export const ACTIVITY_LOG = {
isolatedAction: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.action.isolated',
{
defaultMessage: 'isolated host',
defaultMessage: 'submitted isolate host',
}
),
unisolatedAction: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.action.unisolated',
{
defaultMessage: 'released host',
defaultMessage: 'submitted release host',
}
),
},
response: {
isolationSuccessful: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.response.isolationSuccessful',
{
defaultMessage: 'host isolation successful',
defaultMessage: 'host isolation acknowledged',
}
),
isolationFailed: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.response.isolationFailed',
{
defaultMessage: 'host isolation failed',
defaultMessage: 'host isolation acknowledged with errors',
}
),
unisolationSuccessful: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.response.unisolationSuccessful',
{
defaultMessage: 'host release successful',
defaultMessage: 'host release acknowledged',
}
),
unisolationFailed: i18n.translate(
'xpack.securitySolution.endpointDetails.activityLog.logEntry.response.unisolationFailed',
{
defaultMessage: 'host release failed',
defaultMessage: 'host release acknowledged with errors',
}
),
},
Expand Down