Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] update text for Isolation action submissions #105956

Merged
merged 8 commits into from
Jul 19, 2021
Merged

[Security Solution] update text for Isolation action submissions #105956

merged 8 commits into from
Jul 19, 2021

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Jul 16, 2021 •
edited
Loading

Summary

Update text in the Cases and Activity log to reflect that actions are submitted and acknowledged.

Text in Activity log:
image

Text in Cases:
image

Checklist

Delete any items that are not applicable to this PR.

@kevinlog kevinlog marked this pull request as ready for review July 16, 2021 18:43
@kevinlog kevinlog requested review from a team as code owners July 16, 2021 18:43
@kevinlog kevinlog added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jul 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kevinlog kevinlog added 7.14.0 v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 16, 2021
dasansol92
dasansol92 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@dasansol92 dasansol92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a suggestion but nothing that should hold this up, it LGTM! 🔥

...s/cases/public/components/user_action_tree/user_action_host_isolation_comment_event.test.tsx Outdated
@@ -26,7 +26,7 @@ describe('UserActionHostIsolationCommentEvent', () => {
it('renders with the correct action and hostname', async () => {
const wrapper = mount(<HostIsolationCommentEvent {...defaultProps()} />);
expect(wrapper.find(`[data-test-subj="actions-link-e1"]`).first().exists()).toBeTruthy();
expect(wrapper.text()).toBe('isolated host host1');
expect(wrapper.text()).toBe('isolate submitted on host host1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Using ISOLATED_HOST variable would be better to avoid change texts in tests.

@dasansol92
Copy link
Contributor

Did you forget the auto-backport label?

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kevinlog kevinlog added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 19, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 527.3KB 527.4KB +40.0B
securitySolution 6.3MB 6.3MB +140.0B
total +180.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 15285bf into elastic:master Jul 19, 2021
@kevinlog kevinlog deleted the task/update-isolate-action-text branch July 19, 2021 19:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2021
@kevinlog @kibanamachine
[Security Solution] update text for Isolation action submissions (ela…
c86b3a4 
…stic#105956)
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.14 Commit could not be cherrypicked due to conflicts
✅ 7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 105956

kevinlog added a commit to kevinlog/kibana that referenced this pull request Jul 19, 2021
@kevinlog
[Security Solution] update text for Isolation action submissions (ela…
6efde86 
…stic#105956)

# Conflicts:
#	x-pack/plugins/cases/public/components/user_action_tree/user_action_host_isolation_comment_event.test.tsx
@kevinlog kevinlog mentioned this pull request Jul 19, 2021
Merged
kibanamachine added a commit that referenced this pull request Jul 19, 2021
@kibanamachine @kevinlog
[Security Solution] update text for Isolation action submissions (#10…
c4c6844 
…5956) (#106149)

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
kevinlog added a commit that referenced this pull request Jul 19, 2021
@kevinlog
[Security Solution] update text for Isolation action submissions (#10…
49a2712 
…5956) (#106156)

# Conflicts:
#	x-pack/plugins/cases/public/components/user_action_tree/user_action_host_isolation_comment_event.test.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/onl…
17cbcc0 
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@dasansol92 dasansol92 dasansol92 approved these changes

@parkiino parkiino Awaiting requested review from parkiino

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinlog @elasticmachine @dasansol92 @kibanamachine @cnasikas @brianseeders