Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: APM RUM Source map API #105332

Merged
merged 3 commits into from
Jul 19, 2021
Merged

docs: APM RUM Source map API #105332

merged 3 commits into from
Jul 19, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jul 12, 2021

  • Adds documentation for the new APM RUM API.
  • Renames spaces privilege to feature privilege.
  • Renames APM privilege to APM and User Experience

@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 12, 2021
@bmorelli25 bmorelli25 self-assigned this Jul 12, 2021
@bmorelli25 bmorelli25 requested review from cauemarcondes and a team July 12, 2021 21:12
Comment on lines 629 to 631
`sourcemap`::
(required, string) The source map. It must follow the
https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k[Source map revision 3 proposal].
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauemarcondes, is this a string? I couldn't tell. Is there a way to upload via a file like in APM Server's API?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 I opened a PR to add support to upload via file #105443. Now the POST API can accept both a string or a file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs have been updated

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit fc49ae1 into elastic:master Jul 19, 2021
@bmorelli25 bmorelli25 deleted the apm-api-rum branch July 19, 2021 20:29
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Jul 19, 2021
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Jul 19, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants