Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses #106118

Conversation

paul-tavares
Copy link
Contributor

Summary

Address the following issues:

  1. Comment out the display of Pending isolation statuses (Fixes [Security Solution] The status after releasing shows 'Isolated' whereas it should show 'released' #104295 )
  2. Change the Release (un-isolate) form to match Mocks (use EuiForm + EuiFormRow) (Fixes [Security Solution] Host Isolation Isolate and Release forms look inconsistent #106014 )

olm-10614-104295-isolation-fixes

@paul-tavares paul-tavares added v8.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v7.15.0 labels Jul 19, 2021
@paul-tavares paul-tavares self-assigned this Jul 19, 2021
@paul-tavares paul-tavares requested a review from a team as a code owner July 19, 2021 15:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@paul-tavares paul-tavares added the release_note:skip Skip the PR/issue when compiling release notes label Jul 19, 2021
@paul-tavares paul-tavares requested a review from a team as a code owner July 19, 2021 18:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB -3.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit 879b1a4 into elastic:master Jul 19, 2021
@paul-tavares paul-tavares deleted the fix/olm-10614-and-104295-host-isolation-bugs branch July 19, 2021 20:54
paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Jul 19, 2021
…forms and remove display of Pending isolation statuses (elastic#106118)

* comment out UI display of pending isolation statuses and associated tests
* Change un-isolate form to use `EuiForm` and `EuiFormRow`
* Fix: move component `displayName` to file that has that component's src
paul-tavares added a commit that referenced this pull request Jul 19, 2021
…forms and remove display of Pending isolation statuses (#106118) (#106173)

* comment out UI display of pending isolation statuses and associated tests
* Change un-isolate form to use `EuiForm` and `EuiFormRow`
* Fix: move component `displayName` to file that has that component's src
paul-tavares added a commit that referenced this pull request Jul 19, 2021
…forms and remove display of Pending isolation statuses (#106118) (#106172)

* comment out UI display of pending isolation statuses and associated tests
* Change un-isolate form to use `EuiForm` and `EuiFormRow`
* Fix: move component `displayName` to file that has that component's src
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v7.15.0 v8.0.0
Projects
None yet
4 participants