Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove watcher integration #71655

Merged
merged 2 commits into from
Jul 15, 2020
Merged

[APM] Remove watcher integration #71655

merged 2 commits into from
Jul 15, 2020

Conversation

sorenlouv
Copy link
Member

Closes #70324

@sorenlouv sorenlouv requested a review from a team as a code owner July 14, 2020 14:29
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

smith
smith approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once the i18n check is fixed.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
apm 649 -1 650

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit f760d85 into elastic:master Jul 15, 2020
@sorenlouv sorenlouv deleted the remove-watcher-integration branch July 15, 2020 06:42
@sorenlouv
Copy link
Member Author

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 7.x: Commit could not be cherrypicked due to conflicts

sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jul 15, 2020
@sorenlouv
[APM] Remove watcher integration (elastic#71655)
ccc6dd6 
# Conflicts:
#	x-pack/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/esResponse.ts
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jul 15, 2020
@sorenlouv
[APM] Remove watcher integration (elastic#71655)
97be60f 
# Conflicts:
#	x-pack/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/esResponse.ts
@sorenlouv sorenlouv mentioned this pull request Jul 15, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 15, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
6b090eb 
* master: (82 commits)
  Fixed the spacing of child accordion items for policy response dialog. (elastic#71677)
  [SECURITY] Timeline bug 7.9 (elastic#71748)
  use fixed isChromeVisible method (elastic#71813)
  [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted (elastic#71792)
  [test] Skips flaky Saved Objects Management test
  [APM] Remove watcher integration (elastic#71655)
  [APM] Increase `xpack.apm.ui.transactionGroupBucketSize` (elastic#71661)
  [test] Skips Ingest Manager test preventing ES promotion
  [test] Skips flaky detection engine tests
  Revert "re-fix navigate path for master add SAML login to login_page (elastic#71337)"
  [tests] Temporarily skipped Fleet tests
  [test] Skipped monitoring test
  [Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update (elastic#71794)
  Add endpoint exception creation API validation (elastic#71791)
  Skip jest tests that timeout waiting for react (elastic#71801)
  [Security Solution][Exceptions] - Adds filtering to endpoint index patterns by exceptional fields (elastic#71757)
  [Reporting] Re-delete a file (elastic#71730)
  [Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)
  [Ingest Manager] Better display of Fleet requirements (elastic#71686)
  [tests] Temporarily skipped to promote snapshot
  ...
sorenlouv added a commit that referenced this pull request Jul 15, 2020
@sorenlouv
[APM] Remove watcher integration (#71655) (#71816)
f61061a
@sorenlouv sorenlouv added the apm:test-plan-7.9.0 Test plan for 7.9 release label Jul 16, 2020
@cauemarcondes cauemarcondes self-assigned this Jul 21, 2020
@cauemarcondes
Copy link
Contributor

tests ok:
✅ Chrome
✅ FF
✅ Safari
Screenshot 2020-07-21 at 16 06 24

@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

Assignees

@cauemarcondes cauemarcondes

Labels
apm:test-plan-7.9.0 Test plan for 7.9 release apm:test-plan-done Pull request that was successfully tested during the test plan release_note:deprecation Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Remove the watcher integration and document the watcher error reporting
5 participants
@sorenlouv @elasticmachine @kibanamachine @cauemarcondes @smith