[Ingest Manager] Better display of Fleet requirements #71686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
reviewed
Jul 14, 2020
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
| link: ( | ||
| <EuiLink | ||
| href="https://www.elastic.co/guide/en/ingest-management/current/index.html" | ||
| target="_blank" |
There was a problem hiding this comment.
cc @hbharding what do you think of using external={true} for this EuiLink instead of target="_blank"? this will add an icon next to it too
There was a problem hiding this comment.
Yeah good call thanks Jen. @nchaulet can you add that prop?
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
hbharding
reviewed
Jul 14, 2020
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Show resolved
Hide resolved
jen-huang
approved these changes
Jul 14, 2020
...lugins/ingest_manager/public/applications/ingest_manager/sections/fleet/setup_page/index.tsx
Outdated
Show resolved
Hide resolved
nchaulet
force-pushed
the
feature-better-display-fleet-requirements
branch
2 times, most recently
from
fd9aeef
to
681ff44
Compare
|
The designs included a code snippet for for Kibana configuration items that can be copy/pasted. I am only realizing now that my designs forgot to include information about Kibana encryption keys. Here is what I propose:
However, I am confused by whats included in our docs. They mention both |
|
@nchaulet lets just show |
nchaulet
force-pushed
the
feature-better-display-fleet-requirements
branch
from
681ff44
to
7a15efd
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 15, 2020
tylersmalley
pushed a commit
that referenced
this pull request
Jul 15, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: (82 commits) Fixed the spacing of child accordion items for policy response dialog. (elastic#71677) [SECURITY] Timeline bug 7.9 (elastic#71748) use fixed isChromeVisible method (elastic#71813) [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted (elastic#71792) [test] Skips flaky Saved Objects Management test [APM] Remove watcher integration (elastic#71655) [APM] Increase `xpack.apm.ui.transactionGroupBucketSize` (elastic#71661) [test] Skips Ingest Manager test preventing ES promotion [test] Skips flaky detection engine tests Revert "re-fix navigate path for master add SAML login to login_page (elastic#71337)" [tests] Temporarily skipped Fleet tests [test] Skipped monitoring test [Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update (elastic#71794) Add endpoint exception creation API validation (elastic#71791) Skip jest tests that timeout waiting for react (elastic#71801) [Security Solution][Exceptions] - Adds filtering to endpoint index patterns by exceptional fields (elastic#71757) [Reporting] Re-delete a file (elastic#71730) [Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768) [Ingest Manager] Better display of Fleet requirements (elastic#71686) [tests] Temporarily skipped to promote snapshot ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #70034
Better display of Fleet requirements
UI Change
How to tests
Try to run Elasticsearch without the API key flag