[Ingest Manager] Fix enrollment key selection #73062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
commented
Jul 23, 2020
| @@ -536,9 +536,9 @@ export const AgentListPage: React.FunctionComponent<{}> = () => { | |||
| ), | |||
| }} | |||
| /> | |||
| ) : !isLoading && totalAgents === 0 ? ( | |||
| ) : ( | |||
There was a problem hiding this comment.
This fix a blinking on the agent list page when there is no agents
|
@elasticmachine merge upstream |
nchaulet
added
the
bug
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jen-huang
approved these changes
Jul 28, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 28, 2020
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 28, 2020
nchaulet
added a commit
that referenced
this pull request
Jul 29, 2020
nchaulet
added a commit
that referenced
this pull request
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #72717 #72531
Fix enrollment key selection in the agent enrollment flyout.
Also I named all the
useEffectfunction to act as documentation as it started to be hard to understand all the dependencies and what effect is doing what.How to reproduce the bug
UI Change