[Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group #82472

gmmorris · 2020-11-03T18:48:04Z

Summary

Closes #82274

This PR:

Adds a RunsWhen field to actions in the Alerts Flyout when creating / editing an Alert
Refactores the ActionsForm component into 3 separate components to improve rendering performance and reduce unnecessary rerenders.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

This reverts commit e9f2cd0.

* master: (127 commits) [ILM] Fix breadcrumbs (elastic#82594) [UX]Swap env filter with percentile (elastic#82246) Add platform's missing READMEs (elastic#82268) [Discover] Adding uiMetric to track Visualize link click (elastic#82344) [Search] Add used index pattern name to the search agg error field (elastic#82604) improve client-side SO client get pooling (elastic#82603) [Security Solution] Unskips Overview tests (elastic#82459) Embeddables/migrations (elastic#82296) [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663) Moving reinstall function outside of promise.all (elastic#82672) Load choropleth layer correctly (elastic#82628) Master backport elastic#81233 (elastic#82642) [Fleet] Allow snake cased Kibana assets (elastic#77515) Reduce saved objects authorization checks (elastic#82204) [data.search] Add request handler context and asScoped pattern (elastic#80775) [ML] Fixes formatting of fields in index data visualizer (elastic#82593) Usage collector readme (elastic#82548) [Lens] Visualization validation and better error messages (elastic#81439) [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490) chore(NA): install microdnf in UBI docker build only (elastic#82611) ...

* master: Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)" (elastic#82706)

elasticmachine · 2020-11-05T17:48:30Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1

LGTM. Works as expected.

I'm seeing a console warning for

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `ActionForm`. See https://fb.me/react-warning-keys for more information.
    in ActionTypeForm (created by ActionForm)
    in ActionForm
    in Suspense
    in Unknown (created by AlertForm)

gmmorris · 2020-11-06T10:44:15Z

Check the render method of ActionForm. See https://fb.me/react-warning-keys for more information.

Good catch, thanks. :)
Fixed

mikecote

Changes LGTM! I did a local test on the index threshold, added an action group and it showed in the UI, saved, etc. This is going to be a great feature!

gmmorris · 2020-11-09T09:36:21Z

@elasticmachine merge upstream

kibanamachine · 2020-11-09T11:25:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d1c5e2d

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`triggersActionsUi`	285	287	+2

async chunks size

id	before	after	diff
`triggersActionsUi`	1.5MB	1.5MB	+6.8KB

History

💚 Build #86354 succeeded 6fe4ae4
💚 Build #86208 succeeded 38fb659
💔 Build #86192 failed afc6e81
💔 Build #86178 failed 4b36391
💚 Build #86082 succeeded 73fe0a8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ction to an Action Group (elastic#82472) Adds a `RunsWhen` field to actions in the Alerts Flyout when creating / editing an Alert which allows the user to assign specific actions to a certain Action Groups

* master: Added `defaultActionMessage` to index threshold alert UI type definition (elastic#80936) [ILM] Migrate Delete phase and name field to Form Lib (elastic#82834) skip flaky suite (elastic#57426) [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (elastic#82472) [APM] Expose APM event client as part of plugin contract (elastic#82724) [Logs UI] Fix errors during navigation (elastic#78319) Enable send to background in TSVB (elastic#82835) SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (elastic#82693) [Ingest Manager] Unify install* under installPackage (elastic#82916)

…ction to an Action Group (#82472) (#82946) Adds a `RunsWhen` field to actions in the Alerts Flyout when creating / editing an Alert which allows the user to assign specific actions to a certain Action Groups

…e-details-overlay * 'master' of github.com:elastic/kibana: (201 commits) Added `defaultActionMessage` to index threshold alert UI type definition (elastic#80936) [ILM] Migrate Delete phase and name field to Form Lib (elastic#82834) skip flaky suite (elastic#57426) [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (elastic#82472) [APM] Expose APM event client as part of plugin contract (elastic#82724) [Logs UI] Fix errors during navigation (elastic#78319) Enable send to background in TSVB (elastic#82835) SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (elastic#82693) [Ingest Manager] Unify install* under installPackage (elastic#82916) [Fleet] Make stream id unique in agent policy (elastic#82447) skip flaky suite (elastic#82915) skip flaky suite (elastic#75794) Copy `dateAsStringRt` to observability plugin (elastic#82839) [Maps] rename connected_components/map folder to mb_map (elastic#82897) [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619) [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546) Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056) [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090) Move single use function in line (elastic#82885) [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636) ...

plugged Task Manager lifecycle into status reactively

01c7c7d

gmmorris changed the title ~~plugged Task Manager lifecycle into status reactively~~ added action group field in alert flyout Nov 3, 2020

gmmorris added 12 commits November 5, 2020 11:21

fixed tests

e9f2cd0

Revert "fixed tests"

42395e9

This reverts commit e9f2cd0.

made action group fields optional

6d00ce8

revert deletion

89deeca

again

73fe0a8

Merge branch 'master' into alerts/assign-action-groups

401d99f

* master: Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)" (elastic#82706)

extracted action type for mto its own component

78873a1

extracted more sections of the action form to their own components

85a1068

updated icon

44eb670

added docs

4b36391

fixed always firing alert

afc6e81

gmmorris added Feature:Alerting release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0 labels Nov 5, 2020

gmmorris marked this pull request as ready for review November 5, 2020 17:48

gmmorris requested review from a team as code owners November 5, 2020 17:48

gmmorris changed the title ~~added action group field in alert flyout~~ [Alerting] adds an Run When field in the alert flyout t oasign the actio nto an Actio nGroup Nov 5, 2020

gmmorris changed the title ~~[Alerting] adds an Run When field in the alert flyout t oasign the actio nto an Actio nGroup~~ [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group Nov 5, 2020

fixed export of components

38fb659

ymao1 approved these changes Nov 5, 2020

View reviewed changes

fixed react warning

6fe4ae4

mikecote self-requested a review November 6, 2020 13:54

mikecote approved these changes Nov 6, 2020

View reviewed changes

ryankeairns approved these changes Nov 6, 2020

View reviewed changes

Merge branch 'master' into alerts/assign-action-groups

d1c5e2d

gmmorris merged commit 3c525d7 into elastic:master Nov 9, 2020

gmmorris mentioned this pull request Nov 9, 2020

[7.x] [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (#82472) #82946

Merged

mikecote added the needs_docs label Dec 16, 2020

gmmorris mentioned this pull request Feb 22, 2021

[Docs][Alerting] updates images in Alerts Management and adds docs for the Run When field #92225

Merged

6 tasks

gmmorris removed the needs_docs label Feb 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group #82472

[Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group #82472

gmmorris commented Nov 3, 2020 •

edited

Loading

elasticmachine commented Nov 5, 2020

ymao1 left a comment

gmmorris commented Nov 6, 2020

mikecote left a comment

gmmorris commented Nov 9, 2020

kibanamachine commented Nov 9, 2020

[Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group #82472

[Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group #82472

Conversation

gmmorris commented Nov 3, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Nov 5, 2020

ymao1 left a comment

Choose a reason for hiding this comment

gmmorris commented Nov 6, 2020

mikecote left a comment

Choose a reason for hiding this comment

gmmorris commented Nov 9, 2020

kibanamachine commented Nov 9, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

gmmorris commented Nov 3, 2020 •

edited

Loading