SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search

[pgayvallet]

Summary

Fix #5734 Fix #20242

See #5734 (comment) for more context about the implementation design.

• Adapt getQueryParams to add per-field match_phrase_prefix clauses when the user is performing a prefix search (* wildcard at the end of the query)
• cleanup getQueryParams to no longer relies on mapping, and uses the SO type registry as single source of truth regarding declared types

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

Release notes

Fix a bug causing searching for saved objects using special characters such as * or - to not return any results.

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[rudolf]

Left a question, but otherwise lgtm

[rudolf]

Don't really know how this API works, but does it matter that we're creating a query like:

"should": [
        {
          "simple_query_string": {
            "query": "my-vis*",
            "fields": [
              "visualization.title",
              "visualization.description"
            ],
            "default_operator": "OR"
          }
        },
        {
          "match_phrase_prefix": {
            "visualization.title": {
              "query": "my-vis",
              "boost": 1
            }
          }
        },
        {
          "match_phrase_prefix": {
            "visualization.description": {
              "query": "my-vis",
              "boost": 1
            }
          }
        }
]

I was expecting it to be:

"should": [
        {
          "simple_query_string": {
            "query": "my-vis*",
            "fields": [
              "visualization.title",
              "visualization.description"
            ],
            "default_operator": "OR"
          }
        },
        {
          "match_phrase_prefix": {
            "visualization.title": {
              "query": "my-vis",
              "boost": 1
            },
            "visualization.description": {
              "query": "my-vis",
              "boost": 1
            }
          }
        }
]

[pgayvallet]

I also was tbh. But match_phrase prefix does not work that way unfortunately (and even if it was, I would expect your syntax to be a AND condition between the fields, where we want a OR). That can creates a lot of clauses in the bool query, but when I discussed it with the ES teams, they told me it should not impact performances in any significative way.

[rudolf]

cleanup getQueryParams to no longer relies on mapping, and uses the SO type registry as single source of truth regarding declared types

❤️

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: cc2cd98

Metrics [docs]

✅ unchanged

History

• 💚 Build #86660 succeeded cc2cd98
• 💚 Build #86063 succeeded 3f46a00
• 💚 Build #86055 succeeded 12af963

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream