Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Redirects for drilldown links #83846

Merged
merged 8 commits into from
Nov 30, 2020
Merged

[DOCS] Redirects for drilldown links #83846

merged 8 commits into from
Nov 30, 2020

Conversation

KOTungseth
Copy link
Contributor

Summary

Closes #83268

Checklist

  • Documentation was added for features that require explanation or tutorials

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Nov 19, 2020
@KOTungseth KOTungseth self-assigned this Nov 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@KOTungseth KOTungseth mentioned this pull request Nov 19, 2020
Closed
@Dosant
Copy link
Contributor

Dosant commented Nov 20, 2020

@elasticmachine merge upstream

Dosant
Dosant approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checked that docLinks that we released with 7.10 will open /url-drilldown.html which displayed "moved content" page.

There are issues with current docsLinks (which are in master, 7.x, 7.10 branches) because subheading structure has changed. So some links won't point to proper page section. See below. I think it is fine to fix it in separate follow up pr.

docs/user/dashboard/drilldowns.asciidoc
@@ -33,7 +33,7 @@ you can create a drilldown that navigates from the overall status dashboard to a
that shows a single data center or server.

[float]
[[url-drilldown]]
[[url-drilldowns]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L42

I think it is fine to fix docsLinks in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr

docs/user/dashboard/url-drilldown.asciidoc
@@ -137,7 +137,7 @@ Example:


[float]
[[variables]]
[[url-template-variables]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L44

I think it is fine to fix docsLinks in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr

@KOTungseth KOTungseth mentioned this pull request Nov 20, 2020
Merged
@KOTungseth KOTungseth merged commit 480a993 into elastic:master Nov 30, 2020
@KOTungseth KOTungseth deleted the docs/drilldown-redirects branch November 30, 2020 16:18
@KOTungseth KOTungseth mentioned this pull request Nov 30, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Nov 30, 2020
@KOTungseth @kibanamachine
[DOCS] Redirects for drilldown links (elastic#83846)
1ac8f69 
* Fixes lGo to URL links

* Fixes links pt 2

* Added redirects

* Added Lens and reformatted redirects

* Removed lens and fixed broken links

* Fixes to URL drilldowns link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@KOTungseth KOTungseth mentioned this pull request Nov 30, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Nov 30, 2020
@KOTungseth @kibanamachine
[DOCS] Redirects for drilldown links (elastic#83846)
60dd2d1 
* Fixes lGo to URL links

* Fixes links pt 2

* Added redirects

* Added Lens and reformatted redirects

* Removed lens and fixed broken links

* Fixes to URL drilldowns link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Nov 30, 2020
@KOTungseth @kibanamachine
[DOCS] Redirects for drilldown links (#83846) (#84540)
03cdd86 
* Fixes lGo to URL links

* Fixes links pt 2

* Added redirects

* Added Lens and reformatted redirects

* Removed lens and fixed broken links

* Fixes to URL drilldowns link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
e066f65 
* master: (25 commits)
  [Alerting] fixes buggy default message behaviour (elastic#84202)
  [Graph] Use new ES client and change license API (elastic#84398)
  [DOCS] Adds redirect to known plugins page (elastic#84001)
  Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376)
  Adding timestamps to created events so the sorting is stable (elastic#84515)
  [DOCS] Redirects for drilldown links (elastic#83846)
  [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805)
  [Enterprise Search] Migrate shared Schema components (elastic#84381)
  [Discover] Unskip date_nanos and shard links functional tests (elastic#82878)
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 2, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

KOTungseth added a commit that referenced this pull request Dec 7, 2020
@KOTungseth @kibanamachine
[7.10] [DOCS] Redirects for drilldown links (#83846) (#84542)
3103fce 
* [DOCS] Redirects for drilldown links (#83846)

* Fixes lGo to URL links

* Fixes links pt 2

* Added redirects

* Added Lens and reformatted redirects

* Removed lens and fixed broken links

* Fixes to URL drilldowns link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fixes whats new links

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees

@KOTungseth KOTungseth

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] URL drilldown docs link to 404
4 participants
@KOTungseth @elasticmachine @Dosant @kibanamachine