Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Redirects for drilldown links #83846

Merged
merged 8 commits into from
Nov 30, 2020
Merged

[DOCS] Redirects for drilldown links #83846

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9cc9a3
Fixes lGo to URL links
KOTungseth Nov 12, 2020
583172d
Fixes links pt 2
KOTungseth Nov 12, 2020
c0d5462
Added redirects
KOTungseth Nov 17, 2020
15fc55b
Added Lens and reformatted redirects
KOTungseth Nov 18, 2020
d6a9f87
Removed lens and fixed broken links
KOTungseth Nov 18, 2020
6036bd3
Fixes to URL drilldowns link
KOTungseth Nov 19, 2020
50491e1
Merge branch 'master' into docs/drilldown-redirects
kibanamachine Nov 20, 2020
caad05c
Merge branch 'master' into docs/drilldown-redirects
KOTungseth Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions docs/redirects.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,11 @@ This content has moved. See {ref}/index-mgmt.html[Index management].

This content has moved. See <<discover, **Discover**>>.


[role="exclude",id="document-context"]
== View a document in context

This content has moved. See <<discover, **Discover**>>.


[role="exclude",id="document-data"]
== View document data

Expand All @@ -169,3 +167,24 @@ This content has moved. See <<discover, **Discover**>>.
== View field data statistics

This content has moved. See <<discover, **Discover**>>.

[role="exclude",id="url-drilldown"]
== URL drilldown

[float]
[[trigger-picker]]
=== Picking a trigger for a URL drilldown

This page has moved. Refer to <<url-drilldowns>>.

[float]
[[templating]]
=== URL templating

This page has moved. Refer to <<url_templating-language>>.

[float]
[[variables]]
=== Variables

This page has moved. Refer to <<url-template-variables>>.
6 changes: 3 additions & 3 deletions docs/user/dashboard/drilldowns.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ refer https://www.elastic.co/subscriptions[the subscription page].
==============================================

[float]
[[dashboard-drilldown]]
[[dashboard-drilldowns]]
==== Dashboard drilldowns

Dashboard drilldowns enable you to open a dashboard from another dashboard,
Expand All @@ -33,7 +33,7 @@ you can create a drilldown that navigates from the overall status dashboard to a
that shows a single data center or server.

[float]
[[url-drilldown]]
[[url-drilldowns]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L42

I think it is fine to fix docsLinks in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr

==== URL drilldowns

beta[] URL drilldowns enable you to navigate from a dashboard to internal or external URLs.
Expand All @@ -42,7 +42,7 @@ For example, if you have a dashboard that shows data from a Github repository, y
that opens Github from the dashboard.

Some panels support multiple interactions, also known as triggers.
The <<variables,variables>> you use to create a <<url_templating, URL template>> depends on the trigger you choose. URL drilldowns support these types of triggers:
The <<url-template-variables,variables>> you use to create a <<url_templating-language, URL template>> depends on the trigger you choose. URL drilldowns support these types of triggers:

* *Single click* &mdash; A single data point in the visualization.

Expand Down
4 changes: 2 additions & 2 deletions docs/user/dashboard/url-drilldown.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[[url_templating]]
[[url_templating-language]]
=== URL templating

beta[]
Expand Down Expand Up @@ -137,7 +137,7 @@ Example:


[float]
[[variables]]
[[url-template-variables]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L44

I think it is fine to fix docsLinks in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr

==== URL template variables

The URL drilldown template has three sources for variables:
Expand Down
2 changes: 1 addition & 1 deletion docs/user/whats-new.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ coming[8.0.0]

// tag::notable-highlights[]

// end::notable-highlights[]
// end::notable-highlights[]