Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix Workspace hidden when using Safari #92616

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Feb 24, 2021

Summary

Fixes #92577

This is my attempt to fix the Safari bug with the Drag&Drop styling of the workspace area.

@dej611 dej611 added Feature:Lens release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Feb 24, 2021
@dej611
Copy link
Contributor Author

dej611 commented Feb 24, 2021

Integrated @mbondyra solution which is lighter than the original one proposed here.

@mbondyra
Copy link
Contributor

Tested in FF, Safari and Chrome, looks good to me!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 918.2KB 917.8KB -396.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 24, 2021
@dej611 dej611 marked this pull request as ready for review February 24, 2021 17:55
@dej611 dej611 requested a review from a team February 24, 2021 17:55
@dej611 dej611 requested a review from a team as a code owner February 24, 2021 17:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code LGTM

@mbondyra mbondyra self-requested a review February 24, 2021 18:10
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Safari and works fine. However I noticed it's not possible to select fields via tab, I'm going to open a new issue for this

@dej611 dej611 merged commit 27f6a3b into elastic:master Feb 25, 2021
@dej611 dej611 deleted the fix/92577 branch February 25, 2021 08:42
dej611 added a commit to dej611/kibana that referenced this pull request Feb 25, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
dej611 added a commit that referenced this pull request Feb 25, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>

Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
* master: (38 commits)
  Fixes Cypress flake by adding pipe, click, and should (elastic#92762)
  [Discover] Fix filtering selected sidebar fields (elastic#91828)
  [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625)
  [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513)
  add dep on `@kbn/config` so it is built first
  [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481)
  [Lens] Fix Workspace hidden when using Safari (elastic#92616)
  [Lens] Fixes vertical alignment validation messages (elastic#91878)
  forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359)
  [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081)
  [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570)
  [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634)
  Automatically generated Api documentation (elastic#86232)
  Increase index pattern select limit to 1000 (elastic#92093)
  [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492)
  [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281)
  [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565)
  [Dashboard] Export appropriate references from byValue panels (elastic#91567)
  [Upgrade Assistant] Align code between branches (elastic#91862)
  [Security Solution][Case] Fix alerts push (elastic#91638)
  ...
dej611 added a commit to dej611/kibana that referenced this pull request Mar 2, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
dej611 added a commit that referenced this pull request Mar 2, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>

Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Drop to workplace not shown in Safari
6 participants