Improve perf of sync device lists #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's almost always more efficient to query the rooms that have device list changes, rather than looking at the list of all users whose devices have changed and then look for shared rooms.
erikjohnston
force-pushed
the
erikj/faster_sync_devices
branch
from
8201e3b
to
ca001e8
Compare
erikjohnston
commented
May 14, 2024
| @@ -1475,7 +1462,7 @@ async def get_device_list_changes_in_rooms( | |||
|
|
|||
| sql = """ | |||
| SELECT DISTINCT user_id FROM device_lists_changes_in_room | |||
| WHERE {clause} AND stream_id >= ? | |||
| WHERE {clause} AND stream_id > ? | |||
There was a problem hiding this comment.
This is actually a bug that we didn't catch as we didn't test this code path much. I don't think its much of a problem, we'll just keep sending down the same device list repeatedly until the stream ID increments.
anoadragon453
approved these changes
May 14, 2024
| @@ -1475,7 +1462,7 @@ async def get_device_list_changes_in_rooms( | |||
|
|
|||
| sql = """ | |||
| SELECT DISTINCT user_id FROM device_lists_changes_in_room | |||
| WHERE {clause} AND stream_id >= ? | |||
| WHERE {clause} AND stream_id > ? | |||
Yeah, we do have quite a few tests for device lists, which should now all test this code path (rather than the other one...) |
erikjohnston
added a commit
that referenced
this pull request
May 16, 2024
This reverts commit 0b91ccc.
erikjohnston
added a commit
that referenced
this pull request
May 16, 2024
erikjohnston
added a commit
that referenced
this pull request
May 18, 2024
It's almost always more efficient to query the rooms that have device list changes, rather than looking at the list of all users whose devices have changed and then look for shared rooms.
erikjohnston
added a commit
that referenced
this pull request
May 21, 2024
Mic92
pushed a commit
to Mic92/synapse
that referenced
this pull request
Jun 14, 2024
Re-introduces element-hq#17191, and includes element-hq#17197 and element-hq#17214 The basic idea is to stop calling `get_rooms_for_user` everywhere, and instead use the table `device_lists_changes_in_room`. Commits reviewable one-by-one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's almost always more efficient to query the rooms that have device list changes, rather than looking at the list of all users whose devices have changed and then look for shared rooms.