Merge pull request #20490 from emberjs/types/route-serialize-fix

[BUGFIX stable] Fix model arg to a Route `serialize`
emberjs · Jun 29, 2023 · d2b746b · d2b746b
2 parents 8123d56 + 3b83530
commit d2b746b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/@ember/routing/route.ts b/packages/@ember/routing/route.ts
@@ -335,7 +335,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
     @since 1.0.0
     @public
   */
-  serialize(model: Model | undefined, params: string[]): { [key: string]: unknown } | undefined {
+  serialize(model: Model, params: string[]): { [key: string]: unknown } | undefined {
     if (params.length < 1 || !model) {
       return;
     }

diff --git a/type-tests/@ember/routing-test/route.ts b/type-tests/@ember/routing-test/route.ts
@@ -35,6 +35,27 @@ class ModelTest extends Route {
   }
 }
 
+class Model {
+  baseClass = true;
+}
+
+class Child extends Model {
+  baseClass = false;
+  extraStuff = true;
+}
+
+class FooRoute<T extends Model> extends Route<T> {
+  serialize(object: T): any {
+    return null;
+  }
+}
+
+class FooChildRoute extends FooRoute<Child> {
+  serialize(object: Child) {
+    return object.extraStuff;
+  }
+}
+
 class QPsTest extends Route {
   queryParams = {
     memberQp: { refreshModel: true },