[BUGFIX stable] Fix model arg to a Route serialize
#20490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the internal type here always explicitly added `| undefined` to the type of the `model` param. This was likely reasonable when the conversion first happened, since the type here was simply a minimal `IModel | undefined`. Since the param is now driven by the type param for the `Route`, though, and defaults to `unknown`, we can just use the `Model` type param directly, and the implementation handles it correctly since the was actually already, albeit invisibly, just `unknown`, since `unknown | undefined` === `unknown`.
gitKrystan
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the internal type here always explicitly added
| undefinedto the type of themodelparam. This was likely reasonable when the conversion first happened, since the type here was simply a minimalIModel | undefined. Since the param is now driven by the type param for theRoute, though, and defaults tounknown, we can just use theModeltype param directly, and the implementation handles it correctly since the was actually already, albeit invisibly, justunknown, sinceunknown | undefined===unknown.Fixes #20487.