-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_sse1 does not validate as asm.js. #3043
Comments
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1108870 about the first validation error. |
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1108877 about a bug which is blocking the proper fix for the second validation error. |
Fwiw, bug 1108870 has been fixed, patch in bug 1108877 is r+'d and waits for @sunfishcode landing it. |
Bugs 1108870 and 1108877 have both landed. |
Validates correctly in current incoming. |
Change the default value of STACK_OVERFLOW_CHECK in builds with ASSERTIONS from 2 to 1. This means that plain debug builds (-O0, which enables ASSERTIONS) do not have the most expensive stack checks on by default. You can still add them with -s STACK_OVERFLOW_CHECK=2. The most expensive checks seem excessive to run by default. I don't think any platform does them. However, there is slightly more risk in wasm since we don't have memory protection to give a guarantee of a trap. But the default stack protections can be enough to detect that in most cases. (The default protection, 1, writes a cookie and asserts the cookie is not overwritten at various times. The expensive checks modify the wasm to make every stack allocation check the limit.) See #3043, this removes some work we were doing by default after link, so it makes the link stage simpler.
Build the newly merged SSE1 completeness test with
and run in current Nightly. It will produce a validation error
If one builds with
-g2
flag in addition to above, the error changes to the following:where the offending line reads
The text was updated successfully, but these errors were encountered: