Change STACK_OVERFLOW_CHECK to 1 by default, and not 2. #11989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default value of
STACK_OVERFLOW_CHECK
in builds withASSERTIONS
from 2 to 1. This means that plain debug builds (
-O0
, which enablesASSERTIONS
) do not have the most expensive stack checks on by default. Youcan still add them with
-s STACK_OVERFLOW_CHECK=2
.The most expensive checks seem excessive to run by default. I don't think any
platform does them. However, there is slightly more risk in wasm since we don't
have memory protection to give a guarantee of a trap. But the default stack
protections can be enough to detect that in most cases.
(The default protection, 1, writes a cookie and asserts the cookie is not overwritten
at various times. The expensive checks modify the wasm to make every stack
allocation check the limit.)
See #3043, this removes some work we were doing by default after link, so it
makes the link stage simpler.