Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use earlier macOS for earlier Python versions #1789

Closed
wants to merge 4 commits into from

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Apr 24, 2024

This PR should get the CI back to a working baseline state. It fixes one of the various reasons that CI is currently failing on the main branch: GitHub Actions switched to ARM runners for macos-latest, and the setup-python action doesn't have Python 3.8 and 3.9 builds available for those ARM runners.

The PR also includes a version constraint on PySide6, to work around #1787, and the addition of defusedxml to the test dependencies, since it's needed by the most recent versions of Sphinx.

@mdickinson mdickinson marked this pull request as draft April 24, 2024 11:09
@mdickinson
Copy link
Member Author

Marking this as ready for review. I'll fix the test-from-pypi workflow separately.

@flongford Another one for you, if you have the cycles. The branch protections will need to be updated for the new matrix combinations; I'll do that immediately prior to merge.

@mdickinson mdickinson marked this pull request as ready for review April 24, 2024 13:40
@mdickinson mdickinson changed the title WIP: Use earlier macOS for earlier Python versions Use earlier macOS for earlier Python versions Apr 24, 2024
@@ -15,6 +15,19 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
# Python 3.8 and 3.9 are no longer available on macos-latest, so
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about taking a slightly different approach here: just including macos-13 in the matrix and then excluding just the two cases that we know don't work. That would mean that for more recent versions of Python, we'd be testing on both Intel and Apple Silicon-based Macs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense if we're not too concerned by any additional cost that the new macos-13 runners would introduce.

Copy link

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, since the changes appear to resolve the CI failures reported.

Happy to go along with any approach we take for testing different (supported) macOS os + python-runner combinations.

@mdickinson
Copy link
Member Author

I'm going to leave this open for a bit; it looks as though we might have Python 3.8 and 3.9 available again on macos-latest soon, in which case this PR won't be necessary: actions/setup-python#808

@mdickinson
Copy link
Member Author

Python 3.8 and Python 3.9 are now available again via setup-python on GitHub-hosted macos-latest runners, so this PR is no longer necessary.

@mdickinson mdickinson closed this Apr 29, 2024
@mdickinson mdickinson deleted the fix/use-older-macos-for-older-python branch April 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants