Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use earlier macOS for earlier Python versions #1789

Closed
wants to merge 4 commits into from
Closed

Use earlier macOS for earlier Python versions #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
813465e
Use earlier macOS for earlier Python versions
mdickinson Apr 24, 2024
e0cf2b7
Remove bonus blank line
mdickinson Apr 24, 2024
f08a87a
Add a workaround for a test that's segfaulting with PySide 6.7.0
mdickinson Apr 24, 2024
6945ea8
Add defusedxml to test dependencies
mdickinson Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/run-traits-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
# Python 3.8 and 3.9 are no longer available on macos-latest, so
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about taking a slightly different approach here: just including macos-13 in the matrix and then excluding just the two cases that we know don't work. That would mean that for more recent versions of Python, we'd be testing on both Intel and Apple Silicon-based Macs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense if we're not too concerned by any additional cost that the new macos-13 runners would introduce.

# use an earlier version.
# xref: https://github.com/actions/setup-python/issues/850
exclude:
- python-version: "3.8"
os: "macos-latest"
- python-version: "3.9"
os: "macos-latest"
include:
- python-version: "3.8"
os: "macos-13"
- python-version: "3.9"
os: "macos-13"

runs-on: ${{ matrix.os }}

Expand Down
7 changes: 6 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,17 @@ def get_long_description():
],
"test": [
"Cython",
# defusedxml is required by the Sphinx test machinery
# for recent versions of Sphinx (including 7.3.7)
"defusedxml",
"flake8",
"flake8-ets",
"mypy",
"numpy",
"pyface",
"PySide6",
# TraitsUI is currently broken with PySide 6.7.0
# xref: https://github.com/enthought/traitsui/issues/2045
"PySide6<6.7",
"setuptools",
"Sphinx>=2.1.0",
"traitsui",
Expand Down
Loading