Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more models to Alitra and refactoring #44

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Added more models to Alitra and refactoring #44

merged 1 commit into from
Apr 22, 2022

Conversation

Christdej
Copy link
Contributor

No description provided.

@Christdej Christdej self-assigned this Apr 5, 2022
@Christdej Christdej marked this pull request as draft April 5, 2022 13:13
tsundvoll
tsundvoll requested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@tsundvoll tsundvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and questions from me. I will review more properly tomorrow.

src/alitra/alignment.py Show resolved Hide resolved
tests/test_alignment.py Outdated Show resolved Hide resolved
src/alitra/alignment.py Outdated Show resolved Hide resolved
@Christdej Christdej force-pushed the move_geometry branch 6 times, most recently from 14f51ba to 44b99cb Compare April 6, 2022 13:00
@Christdej Christdej marked this pull request as ready for review April 6, 2022 13:03
tsundvoll
tsundvoll requested changes Apr 7, 2022
View reviewed changes
src/alitra/models/orientation.py Outdated Show resolved Hide resolved
src/alitra/models/orientation.py Outdated Show resolved Hide resolved
src/alitra/models/transform.py Outdated Show resolved Hide resolved
src/alitra/models/transform.py Outdated Show resolved Hide resolved
tests/models/test_pose.py Outdated Show resolved Hide resolved
tests/models/test_transform.py Outdated Show resolved Hide resolved
aeshub
aeshub reviewed Apr 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
tsundvoll
tsundvoll requested changes Apr 7, 2022
View reviewed changes
src/alitra/models/frame.py Outdated Show resolved Hide resolved
src/alitra/alignment.py Outdated Show resolved Hide resolved
src/alitra/alignment.py Outdated Show resolved Hide resolved
src/alitra/models/map.py Show resolved Hide resolved
src/alitra/models/bounds.py Show resolved Hide resolved
src/alitra/models/orientation.py Show resolved Hide resolved
aeshub
aeshub reviewed Apr 8, 2022
View reviewed changes
src/alitra/models/bounds.py Outdated Show resolved Hide resolved
vetlek
vetlek reviewed Apr 8, 2022
View reviewed changes
src/alitra/__init__.py Outdated Show resolved Hide resolved
@Christdej Christdej force-pushed the move_geometry branch 3 times, most recently from 8c7a30b to 1a1e081 Compare April 8, 2022 07:58
@Christdej Christdej mentioned this pull request Apr 20, 2022
Merged
@Christdej Christdej mentioned this pull request Apr 20, 2022
Merged
aeshub
aeshub approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm happy with the changes that have been made.

@tsundvoll and @vetlek ?

@Christdej Christdej mentioned this pull request Apr 21, 2022
Merged
@Christdej Christdej merged commit 1ad5071 into equinor:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vetlek vetlek vetlek left review comments

@aeshub aeshub aeshub approved these changes

@tsundvoll tsundvoll tsundvoll approved these changes

Assignees

@Christdej Christdej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Christdej @aeshub @tsundvoll @vetlek