Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with new changes in alitra / isar #32

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Align with new changes in alitra / isar #32

merged 1 commit into from
Apr 25, 2022

Conversation

Christdej
Copy link
Contributor

Depends on new version of Alitra equinor/alitra#44

@Christdej Christdej self-assigned this Apr 20, 2022
aeshub
aeshub approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved once tests passes due to Alitra being updated.

@aeshub
Copy link
Contributor

aeshub commented Apr 25, 2022

You should update the workflow file to use setup.py for installation instead of requirements-dev.txt

@aeshub aeshub added the feature New feature or request label Apr 25, 2022
@Christdej Christdej merged commit 5f7a3c5 into equinor:main Apr 25, 2022
@Christdej Christdej deleted the move_geometry branch April 25, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@Christdej Christdej

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christdej @aeshub