Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Documentation folder restructuring #10615

Closed
wants to merge 6 commits into from
Closed

Complete Documentation folder restructuring #10615

wants to merge 6 commits into from

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Apr 4, 2019

This PR completes the Documentation folder restructuring begun in #10596. It removes the docs folder from the root and adds some _index.md files necessary for constructing the site's table of contents in Hugo.

Signed-off-by: lucperkins <lucperkins@gmail.com>
Signed-off-by: lucperkins <lucperkins@gmail.com>
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #10615 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10615      +/-   ##
==========================================
- Coverage    71.8%   71.51%   -0.29%     
==========================================
  Files         393      393              
  Lines       36628    36628              
==========================================
- Hits        26302    26196     -106     
- Misses       8502     8582      +80     
- Partials     1824     1850      +26
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 80.55% <0%> (-13.89%) ⬇️
pkg/fileutil/read_dir.go 91.3% <0%> (-8.7%) ⬇️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-7.96%) ⬇️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
pkg/fileutil/purge.go 65.9% <0%> (-6.82%) ⬇️
pkg/adt/interval_tree.go 87.08% <0%> (-4.81%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
pkg/transport/listener.go 54.5% <0%> (-3.8%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
etcdserver/api/v3election/election.go 66.66% <0%> (-2.78%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29b1ad...1631498. Read the comment docs.

Signed-off-by: lucperkins <lucperkins@gmail.com>
Signed-off-by: lucperkins <lucperkins@gmail.com>
Signed-off-by: lucperkins <lucperkins@gmail.com>
@lucperkins
Copy link
Contributor Author

Could somebody possibly advise me on how I can disable the CI Markdown checks? It's not clear to me that those checks are compatible with the new documentation system.

@lucperkins
Copy link
Contributor Author

I'm going to close this and submit a new PR, which I suspect will be dramatically simpler than rebasing here

@lucperkins lucperkins closed this Nov 6, 2019
@lucperkins lucperkins deleted the lperkins/further-documentation-metadata branch November 6, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants