Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: add v3.4.0 documentation #42

Merged
merged 2 commits into from
Aug 30, 2019
Merged

content: add v3.4.0 documentation #42

merged 2 commits into from
Aug 30, 2019

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 30, 2019

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho requested a review from lucperkins August 30, 2019 16:11
@gyuho gyuho mentioned this pull request Aug 30, 2019
19 tasks
@philips
Copy link

philips commented Aug 30, 2019

This doesn't look right.

New page:
https://deploy-preview-42--etcd.netlify.com/docs/v3.4.0/

Old page:
https://etcd.io/docs/v3.3.12/

Notice the documentation sections is empty and the categories too.

Do not merge this as-is.

@gyuho
Copy link
Contributor Author

gyuho commented Aug 30, 2019

Oh, let me fix

@lucperkins
Copy link
Contributor

@gyuho Several months ago I attempted to add the appropriate structure for the Documentation folder in the etcd repo: etcd-io/etcd#10615. At this point, it's probably too late to merge those changes painlessly, but that PR can act as a guide for how to restructure here. Most notably, see how the _index.md files indicate sections.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented Aug 30, 2019

@lucperkins @philips Now looks good https://deploy-preview-42--etcd.netlify.com/docs/v3.4.0/

@philips philips merged commit d366add into etcd-io:master Aug 30, 2019
@gyuho gyuho deleted the 3.4.0 branch August 30, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants