Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Separate grpc server #15620

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

serathius
Copy link
Member

Backport #15446 and #15588
cc @ahrtr @ptabor

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius changed the title Separate grpc server 3.4 [3.4] Separate grpc server Apr 3, 2023
…er separate from http server

Difference in load configuration for watch delay tests show how huge the
impact is. Even with random write scheduler grpc under http
server can only handle 500 KB with 2 seconds delay. On the other hand,
separate grpc server easily hits 10, 100 or even 1000 MB within 100 miliseconds.

Priority write scheduler that was used in most previous releases
is far worse than random one.

Tests configured to only 5 MB to avoid flakes and taking too long to fill
etcd.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(non-binding)

@serathius serathius merged commit a1a3749 into etcd-io:release-3.4 Apr 4, 2023
@serathius serathius deleted the separate-grpc-server-3.4 branch June 15, 2023 20:41
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 19, 2024
Finish backporting the remaining functions from the original backport
from PR etcd-io#15620.

Backported commit 65add8c

Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 19, 2024
Finish backporting the remaining functions from the original backport
from PR etcd-io#15620.

Backported commit 65add8c

Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 19, 2024
Finish backporting the remaining functions from the original backport
from PR etcd-io#15620.

Backport of commit 65add8c

Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 20, 2024
Finish backporting the remaining functions from the original backport
from PR etcd-io#15620.

Backport of commit 65add8c.

Co-authored-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 20, 2024
Finish backporting the remaining functions from the original backport
from PR etcd-io#15620.

Backport of commit 65add8c.

Co-authored-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants