Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] Separate grpc server #15620

Merged
merged 7 commits into from
Apr 4, 2023
Merged

[3.4] Separate grpc server #15620

merged 7 commits into from
Apr 4, 2023

Commits on Apr 3, 2023

  1. refactor: Use proper variable names for urls 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6de105e View commit details
    Browse the repository at this point in the history

  2. server: Separate client listener grouping from serving 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    66704b4 View commit details
    Browse the repository at this point in the history

  3. server: Extract resolveUrl helper function 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a4ac849 View commit details
    Browse the repository at this point in the history

  4. server: Pick one address that all grpc gateways connect to 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    dd0bc66 View commit details
    Browse the repository at this point in the history

  5. server: Add --listen-client-http-urls flag to allow running grpc serv… 

    …er separate from http server

Difference in load configuration for watch delay tests show how huge the
impact is. Even with random write scheduler grpc under http
server can only handle 500 KB with 2 seconds delay. On the other hand,
separate grpc server easily hits 10, 100 or even 1000 MB within 100 miliseconds.

Priority write scheduler that was used in most previous releases
is far worse than random one.

Tests configured to only 5 MB to avoid flakes and taking too long to fill
etcd.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8dc1244 View commit details
    Browse the repository at this point in the history

  6. tests: Test separate http port connection multiplexing 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    75675cd View commit details
    Browse the repository at this point in the history

  7. server: Fix defer function closure escape 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    47d4ff2 View commit details
    Browse the repository at this point in the history