-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: run 'marker' in CI #7864
*: run 'marker' in CI #7864
Conversation
tools/etcd-dump-db/README.md
Outdated
@@ -38,7 +38,7 @@ meta | |||
``` | |||
|
|||
|
|||
#### hash [data dir or db file path] | |||
#### hash `[data dir or db file path]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not look good.
/cc @crawford can you patch marker to ignore []
checking in the title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to have links in the header though. I would suggest making the heading the command verb and then listing the usage below (/cc @joshix).
Maybe something like:
hash
Computes the hash of db file.
Usage:
etcd-dump-db hash [data dir or db file path] [flags]
Flags:
-h, --help help for hash
$ etcd-dump-db hash agent01/agent.etcd
db path: agent01/agent.etcd/member/snap/db
Hash: 3700260467
$ etcd-dump-db hash agent02/agent.etcd
db path: agent02/agent.etcd/member/snap/db
Hash: 3700260467
$ etcd-dump-db hash agent03/agent.etcd
db path: agent03/agent.etcd/member/snap/db
Hash: 3700260467
@xiang90 @heyitsanthony I made it run only on |
lgtm |
test
Outdated
# TODO: check other markdown files when marker handles headers with '[]' | ||
if which marker >/dev/null; then | ||
echo "Checking marker to find broken links..." | ||
markerResult=`marker --root ./Documentation 2>&1 || true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to use --skip-http
. Otherwise, marker will do a bunch of HEAD and GET requests to check remote resources. This is pretty slow and might spuriously fail.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
To make 'marker' pass the tests Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
lgtm thanks |
Codecov Report
@@ Coverage Diff @@
## master #7864 +/- ##
==========================================
- Coverage 75.76% 75.58% -0.19%
==========================================
Files 332 332
Lines 26203 26203
==========================================
- Hits 19853 19805 -48
- Misses 4923 4968 +45
- Partials 1427 1430 +3
Continue to review full report at Codecov.
|
Fix #7123.