Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix broken links in markdown #7871

Merged
merged 3 commits into from
May 3, 2017
Merged

*: fix broken links in markdown #7871

merged 3 commits into from
May 3, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 3, 2017

Replace #7864.
Fix #7861.

Only cherry-pick the changes for backporting.
Will integrate with marker once it can handle the [...] in markdown headers.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@xiang90
Copy link
Contributor

xiang90 commented May 3, 2017

lgtm

1 similar comment
@fanminshi
Copy link
Member

lgtm

@@ -203,8 +203,9 @@ In [DaoCloud][DaoCloud], we use Docker and Swarm to deploy and run our applicati
- *Environment*: AWS, Kubernetes
- *Backups*: EBS volume backups

At Branch, we use kubernetes heavily as our core microservice platform for staging and production.
[Branch]:https://branch.io
At Branch, we use kubernetes heavily as our core microservice platform for staging and production.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Branch](Branch)?

@codecov-io
Copy link

codecov-io commented May 3, 2017

Codecov Report

Merging #7871 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7871      +/-   ##
=========================================
+ Coverage   75.69%   75.7%   +0.01%     
=========================================
  Files         332     332              
  Lines       26203   26203              
=========================================
+ Hits        19835   19838       +3     
+ Misses       4935    4929       -6     
- Partials     1433    1436       +3
Impacted Files Coverage Δ
clientv3/namespace/lease.go 43.75% <0%> (-31.25%) ⬇️
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
proxy/grpcproxy/lease.go 79.04% <0%> (-9.53%) ⬇️
auth/simple_token.go 86.79% <0%> (-6.61%) ⬇️
proxy/grpcproxy/leader.go 93.87% <0%> (-6.13%) ⬇️
pkg/testutil/recorder.go 66.66% <0%> (-3.71%) ⬇️
etcdserver/api/v3rpc/lease.go 96.42% <0%> (-3.58%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
etcdserver/api/v3rpc/util.go 52.77% <0%> (-2.78%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fee35b...4203320. Read the comment docs.

gyuho added 2 commits May 3, 2017 16:57
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants