This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] Cap Expo CLI at Node 16 #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't work with Node 17 right now. Make this clear in `engines`.
|
We already warn about Node versions when you run the CLI. I it the CLI itself that doesn't support it, or only the upstream cert/webpack/etc issues that are causing some things to break without a workaround? |
EvanBacon
approved these changes
Mar 29, 2022
|
This is for tools such as Volta. I'm not sure if Volta honors engines in application packages specifically but adding this is harmless. |
|
Node 18 is now LTS - it should definitely be added to the |
gnprice
added a commit
to gnprice/zulip-mobile
that referenced
this pull request
Dec 13, 2022
I believe we don't ever use the `expo` CLI. The `expo-cli` package is apparently in maintenance mode. It doesn't and won't support Node 18, the current LTS: expo/expo-cli#4583 expo/expo-cli#4281 That effectively gives it an EOL of 2023-09, the EOL date of Node 16, which is less than a year away. There's a successor CLI in the works: https://blog.expo.dev/the-new-expo-cli-f4250d8e3421 But since we don't actually use this CLI in the first place, we can wait to pick that up until we find a need for it. As a bonus, dropping this sheds about 90MB from our node_modules tree.
gnprice
added a commit
to gnprice/zulip-mobile
that referenced
this pull request
Dec 13, 2022
We don't use the `expo` CLI in normal development; only when upgrading Expo itself. Discussion: zulip#5602 (comment) This `expo-cli` package is apparently in maintenance mode. It doesn't and won't support Node 18, the current LTS: expo/expo-cli#4583 expo/expo-cli#4281 That effectively gives it an EOL of 2023-09, the EOL date of Node 16, which is less than a year away. It also means an error when just trying to run `yarn install` with a newer Node version. So it'd be good to get it out of our dependencies. There's a successor CLI now: https://blog.expo.dev/the-new-expo-cli-f4250d8e3421 That one is shipped with Expo itself, starting with Expo 46. We're on Expo 45 at the moment, so we still have one more upgrade before then; when we go to do that upgrade, we might need some ad-hocery to get the CLI (either the old one or the new one, which IIUC was in beta in the Expo 45 period.) Until then, just drop it. As a bonus, dropping this sheds about 90MB from our node_modules tree. (At least for now; maybe Expo 46 will bring that all back.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It doesn't work with Node 17 right now. Make this clear in
engines.Test Plan
Verified that
>=12 <=16matches numbers like12.4.5and16.1.2.