Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Drop expo-cli #5602

Merged
merged 1 commit into from
Dec 13, 2022
Merged

deps: Drop expo-cli #5602

merged 1 commit into from
Dec 13, 2022

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Dec 13, 2022

I believe we don't ever use the expo CLI.

The expo-cli package is apparently in maintenance mode. It doesn't and won't support Node 18, the current LTS:
expo/expo-cli#4583
expo/expo-cli#4281

That effectively gives it an EOL of 2023-09, the EOL date of Node 16, which is less than a year away.

There's a successor CLI in the works:
https://blog.expo.dev/the-new-expo-cli-f4250d8e3421
But since we don't actually use this CLI in the first place, we can wait to pick that up until we find a need for it.

As a bonus, dropping this sheds about 90MB from our node_modules tree.

@chrisbobbe
Copy link
Contributor

I believe we don't ever use the expo CLI.

We've used it for the past few Expo upgrades (#5441, #5507). We added it in 5b52bc5 after I waffled a bit, and there was some discussion at #5441 (comment). I think it's probably fine to remove it, and if Expo's upgrade guides continue to ask us to use it, we can install it globally instead of in our project's devDependencies.

@gnprice
Copy link
Member Author

gnprice commented Dec 13, 2022

Cool, thanks for the correction.

I think it's probably fine to remove it, and if Expo's upgrade guides continue to ask us to use it, we can install it globally instead of in our project's devDependencies.

Not quite, I think: the new CLI specifically wants us to use the CLI from project dependencies, not a user-global install. Which seems for the best.

Rereading that blog post, though, I realize that it's no longer a separate package -- it's shipped via the expo package. So there's nothing to add; it'll already be there.

(That's the case starting with Expo SDK 46, anyway. So for the remaining upgrade to there from 45, I guess we might need to install the old CLI either globally or locally, and then uninstall it for good.)

I'll revise the commit message and merge.

We don't use the `expo` CLI in normal development; only when
upgrading Expo itself.  Discussion:
  zulip#5602 (comment)

This `expo-cli` package is apparently in maintenance mode.
It doesn't and won't support Node 18, the current LTS:
  expo/expo-cli#4583
  expo/expo-cli#4281

That effectively gives it an EOL of 2023-09, the EOL date of Node 16,
which is less than a year away.  It also means an error when just
trying to run `yarn install` with a newer Node version.  So it'd be
good to get it out of our dependencies.

There's a successor CLI now:
  https://blog.expo.dev/the-new-expo-cli-f4250d8e3421
That one is shipped with Expo itself, starting with Expo 46.
We're on Expo 45 at the moment, so we still have one more upgrade
before then; when we go to do that upgrade, we might need some
ad-hocery to get the CLI (either the old one or the new one,
which IIUC was in beta in the Expo 45 period.)  Until then,
just drop it.

As a bonus, dropping this sheds about 90MB from our node_modules tree.
(At least for now; maybe Expo 46 will bring that all back.)
@gnprice gnprice merged commit ad0e065 into zulip:main Dec 13, 2022
@gnprice gnprice deleted the pr-expo-cli branch December 13, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants