[Android][React DevTools] Support persisted settings in Android #34964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
added
the
Type: Enhancement
Base commit: 31f2199 |
Base commit: 31f2199 |
|
I'm not sure this is a new public API we should be exposing. If React DevTools does need to use a different key/value storage API from what is out there already, maybe we could encapsulate it somewhere that doesn't add newly working public API surface? |
rbalicki2
force-pushed
the
file-storage
branch
11 times, most recently
from
97fd1a9
to
0a4d713
Compare
|
I can't seem to make this a draft, but FYI it's a draft for now |
rbalicki2
force-pushed
the
file-storage
branch
2 times, most recently
from
0a4d713
to
8b655ca
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| * @format | ||
| */ | ||
|
|
||
| import Settings from './Settings'; |
There was a problem hiding this comment.
⚠️ Libraries/Settings/DevToolsSettingsManager.ios.js line 11 – Requires should be sorted alphabetically (lint/sort-imports)
rbalicki2
force-pushed
the
file-storage
branch
7 times, most recently
from
6081537
to
4ceb8eb
Compare
rbalicki2
force-pushed
the
file-storage
branch
from
4ceb8eb
to
ef32895
Compare
rbalicki2
force-pushed
the
file-storage
branch
from
ef32895
to
9a45934
Compare
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @rbalicki2 in 0fac981. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been reverted by 51d14b9. |
rbalicki2
pushed a commit
to rbalicki2/react-native
that referenced
this pull request
Nov 1, 2022
Summary: # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Differential Revision: D40873390 fbshipit-source-id: 9eff55ead8f574ef8def506369c2e28219aa2ce0
rbalicki2
pushed a commit
to rbalicki2/react-native
that referenced
this pull request
Nov 1, 2022
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Differential Revision: D40873390 fbshipit-source-id: 510fa3accb2a9037cd365adad6ba0c9d87d360a8
rbalicki2
pushed a commit
to rbalicki2/react-native
that referenced
this pull request
Nov 1, 2022
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Differential Revision: D40873390 fbshipit-source-id: 4d401f7d0e5051eb25ed984d814d8effd9ad2915
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
…35163) Summary: Pull Request resolved: #35163 # What This diff contains all the changes from D40333083 (0fac981) (aka #34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Reviewed By: NickGerleman Differential Revision: D40873390 fbshipit-source-id: c7bac6ae65f85666b8616443db278ebb175b691b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: * Add a DevToolsSettingsManager, which has android and iOS variants, which uses a new TM (Android) or takes advantage of the Settings TM (iOS) to get/set console patch settings * This is backed by either the existing Settings module (iOS) or a new Java TM, which uses the SharedPreferences AP ## Testing Manual testing ## Changelog [General] [Added] - Add DevToolsSettingsManager Pull Request resolved: facebook#34964 Test Plan: * Extensive manual testing Reviewed By: NickGerleman Differential Revision: D40333083 Pulled By: rbalicki2 fbshipit-source-id: f3816e3bd7dea3086f6f2269c3a099af14aebb3b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Reviewed By: NickGerleman Differential Revision: D40873390 fbshipit-source-id: c7bac6ae65f85666b8616443db278ebb175b691b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Libraries/Settings/Settings. Implement part of that for Android, leavingwatchKeysandclearWatchas no-ops.Turbomodule implementation
{"ReactDevTools::Settings::ConsolePatchSettings":"{\"consolePatchSettings\":{\"appendComponentStack\":false,\"breakOnConsoleErrors\":false,\"showInlineWarningsAndErrors\":true,\"hideConsoleLogsInStrictMode\":true,\"browserTheme\":\"light\"}}"}when used with React DevTools.Integation with DevTools
Changelog
[General] [Added] - Add a SettingsManager TurboModule to Android
Test Plan