Buck, etc. changes that enable persisted, sync settings for DevTools #35163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40873390 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D40873390 |
rbalicki2
pushed a commit
to rbalicki2/react-native
that referenced
this pull request
Nov 1, 2022
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Differential Revision: D40873390 fbshipit-source-id: 510fa3accb2a9037cd365adad6ba0c9d87d360a8
rbalicki2
force-pushed
the
export-D40873390
branch
from
714d968
to
b2805fd
Compare
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Differential Revision: D40873390 fbshipit-source-id: 4d401f7d0e5051eb25ed984d814d8effd9ad2915
rbalicki2
force-pushed
the
export-D40873390
branch
from
b2805fd
to
b89a856
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40873390 |
Base commit: 40ad31e |
Base commit: 40ad31e |
|
PR build artifact for b89a856 is ready. |
|
PR build artifact for b89a856 is ready. |
|
This pull request was successfully merged by Robert Balicki in 6152763. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#35163) Summary: Pull Request resolved: facebook#35163 # What This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files. # Why * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files. * Otherwise, apps can fail at startup with the message: ``` `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` + 'Verify that a module by this name is registered in the native binary.', ``` * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur. * After a few days, we can land the JS files. ## Changelog Changelog [General][Added] Add, but don't use, DevTools Settings Manager. Reviewed By: NickGerleman Differential Revision: D40873390 fbshipit-source-id: c7bac6ae65f85666b8616443db278ebb175b691b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
What
This diff contains all the changes from D40333083 (0fac981) (aka #34964), except the change to
setUpReactDevTools.js, which actually uses the new files.Why
Changelog
[General][Added] Add, but don't use, DevTools Settings Manager.
Differential Revision: D40873390