Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682

mdvacca · 2023-09-26T18:12:52Z

Summary: Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule

Reviewed By: RSNara

Differential Revision: D49523696

facebook-github-bot · 2023-09-26T18:13:21Z

This pull request was exported from Phabricator. Differential Revision: D49523696

analysis-bot · 2023-09-26T18:41:58Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,317,591	-9
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,685,723	-4
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: e1d824f
Branch: main

facebook-github-bot · 2023-10-01T15:59:56Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: c4c052b39bf0ca2c41c4eeb0803dc9fa9fc44d13

facebook-github-bot · 2023-10-04T16:41:09Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 27f52fe752a44de0e8bfe790e4f7c7a0cb2a544f

facebook-github-bot · 2023-10-04T18:54:32Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 4e955f7a0847e1f8916287ca8d5a620868327658

facebook-github-bot · 2023-10-04T23:10:56Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 2eea1170ab280ebdec8cf6374d312ee3ff7341af

facebook-github-bot · 2023-10-05T00:00:20Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 14a423fbaaa73bf099ea1882543350e338391b8d

facebook-github-bot · 2023-10-05T05:09:40Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: d49e0a1be6a76f9f606efb7d1c61b05fbc38a8b8

facebook-github-bot · 2023-10-05T05:42:27Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 6bbaa6b27977ed5b9fa263cdcd876ebdcbe4a62d

facebook-github-bot · 2023-10-05T06:22:49Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: bee4dad68f779efb820c252b4e4dd2142ea5a2b3

facebook-github-bot · 2023-10-05T06:27:55Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: fb713cfb0f141422ebff685cbd0f4936ba7572ed

facebook-github-bot · 2023-10-05T06:34:01Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: e170683a47eaedd028847b8d4d23f70e8b48be44

Summary: Move ReactHost to com.facebook.react chnagelog: [internal] internal Differential Revision: D49834870 fbshipit-source-id: e677fd19d00f4ba779fb277d69dd09f1d3952372

Summary: In this diff I'm removing TurboModuleManager from ReactHostDelegate. The goal is to stop exposing TurboModuleManager and TurboModuleRegistry Developers should use ReactContext.getNativeModule to retrieve native modules instead of TurboModuleManager or TurboModuleRegistry changelog: [internal] internal Differential Revision: D49483636 fbshipit-source-id: b3065f711a67272976751590d9bdc5339c99b439

facebook-github-bot · 2023-10-05T06:41:32Z

This pull request was exported from Phabricator. Differential Revision: D49523696

…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 495b5dab52026c7182ca81023eaa4c11401b2081

github-actions · 2023-10-05T07:54:06Z

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b147838

github-actions · 2023-10-10T02:28:16Z

This pull request was successfully merged by @mdvacca in b7191cd.

^{When will my fix make it into a release? | Upcoming Releases}

facebook-github-bot · 2023-10-10T02:28:19Z

This pull request has been merged in b7191cd.

…odule.kt Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413

…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413

…odule.kt (#41412) Summary: Pull Request resolved: #41412 The PR #39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca

…odule.kt (facebook#41412) Summary: Pull Request resolved: facebook#41412 The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 26, 2023

facebook-github-bot added the fb-exported label Sep 26, 2023

mdvacca force-pushed the export-D49523696 branch from 566a19d to 6f209c1 Compare October 1, 2023 16:00

mdvacca force-pushed the export-D49523696 branch from 6f209c1 to 2faf41a Compare October 4, 2023 16:41

mdvacca force-pushed the export-D49523696 branch from 2faf41a to af7cb2e Compare October 4, 2023 18:54

mdvacca force-pushed the export-D49523696 branch from af7cb2e to 75138b4 Compare October 4, 2023 23:11

mdvacca force-pushed the export-D49523696 branch from 75138b4 to a34c756 Compare October 5, 2023 00:00

mdvacca force-pushed the export-D49523696 branch from a34c756 to c77839e Compare October 5, 2023 05:09

mdvacca force-pushed the export-D49523696 branch from c77839e to b60d990 Compare October 5, 2023 05:42

mdvacca force-pushed the export-D49523696 branch from b60d990 to 0b9f1d0 Compare October 5, 2023 06:23

mdvacca force-pushed the export-D49523696 branch from 0b9f1d0 to 530631a Compare October 5, 2023 06:28

mdvacca force-pushed the export-D49523696 branch from 530631a to b147838 Compare October 5, 2023 06:34

mdvacca added 2 commits October 4, 2023 23:38

Move ReactHost to com.facebook.react

221c95d

Summary: Move ReactHost to com.facebook.react chnagelog: [internal] internal Differential Revision: D49834870 fbshipit-source-id: e677fd19d00f4ba779fb277d69dd09f1d3952372

mdvacca force-pushed the export-D49523696 branch from b147838 to 5fa9071 Compare October 5, 2023 06:41

facebook-github-bot closed this in b7191cd Oct 10, 2023

github-actions bot added the Merged This PR has been merged. label Oct 10, 2023

piaskowyk mentioned this pull request Oct 30, 2023

react-native@0.74 support software-mansion/react-native-reanimated#5328

Closed

mdvacca mentioned this pull request Nov 10, 2023

Introduce again com/facebook/react/turbomodule/core/interfaces/TurboModule.kt #41412

Closed

Icehunter mentioned this pull request Jan 11, 2024

unable to build reanimated with latest react due to turbo module classes removal software-mansion/react-native-reanimated#5574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682

Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682

mdvacca commented Sep 26, 2023

facebook-github-bot commented Sep 26, 2023

analysis-bot commented Sep 26, 2023 •

edited

Loading

facebook-github-bot commented Oct 1, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023 •

edited

Loading

github-actions bot commented Oct 10, 2023

facebook-github-bot commented Oct 10, 2023

Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682

Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682

Conversation

mdvacca commented Sep 26, 2023

facebook-github-bot commented Sep 26, 2023

analysis-bot commented Sep 26, 2023 • edited Loading

facebook-github-bot commented Oct 1, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 4, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

facebook-github-bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023 • edited Loading

github-actions bot commented Oct 10, 2023

facebook-github-bot commented Oct 10, 2023

analysis-bot commented Sep 26, 2023 •

edited

Loading

github-actions bot commented Oct 5, 2023 •

edited

Loading