-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce again com/facebook/react/turbomodule/core/interfaces/TurboModule.kt #41412
Conversation
This pull request was exported from Phabricator. Differential Revision: D51168413 |
Base commit: f53bd56 |
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
3abd88b
to
3a3f6f4
Compare
This pull request was exported from Phabricator. Differential Revision: D51168413 |
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
3a3f6f4
to
8b69935
Compare
This pull request was exported from Phabricator. Differential Revision: D51168413 |
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
8b69935
to
3574f94
Compare
This pull request was exported from Phabricator. Differential Revision: D51168413 |
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
This pull request was exported from Phabricator. Differential Revision: D51168413 |
3574f94
to
79c9b10
Compare
This pull request was successfully merged by @mdvacca in 1891d9e. When will my fix make it into a release? | Upcoming Releases |
…odule.kt (facebook#41412) Summary: Pull Request resolved: facebook#41412 The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca
Summary:
The PR #39682
moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API.
Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method:
https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava
In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility.
Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is:
Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method
Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method
com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API
changelog: [Android][Changed] Fix backward compatibility breakage
Reviewed By: fkgozali
Differential Revision: D51168413