Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockdb 3.2 make check bloom_test failed #223

Closed
zhibaodhu opened this issue Aug 6, 2014 · 9 comments
Closed

rockdb 3.2 make check bloom_test failed #223

zhibaodhu opened this issue Aug 6, 2014 · 9 comments

Comments

@zhibaodhu
Copy link

"make check" only has problem with bloom_test:

***** Running bloom_test
==== Test BloomTest.EmptyFilter
==== Test BloomTest.Small
==== Test BloomTest.VaryingLengths
False positives: 0.00% @ length = 1 ; bytes = 9
False positives: 0.00% @ length = 2 ; bytes = 9
False positives: 0.00% @ length = 3 ; bytes = 9
False positives: 0.00% @ length = 4 ; bytes = 9
False positives: 0.00% @ length = 5 ; bytes = 9
False positives: 0.00% @ length = 6 ; bytes = 9
False positives: 1.50% @ length = 7 ; bytes = 10
False positives: 0.00% @ length = 8 ; bytes = 11
False positives: 2.56% @ length = 9 ; bytes = 13
util/bloom_test.cc:161: failed: 0.0256 <= 0.02
#0 ./bloom_test() [0x1002e9e8] ~BloomTest /tmp/rocksdb/rocksdb-rocksdb-3.2

/util/bloom_test.cc:49
#1 ./bloom_test() [0x10163590] rocksdb::test::RunAllTests() /tmp/rocksdb/roc

ksdb-rocksdb-3.2/util/testharness.cc:59
#2 ./bloom_test() [0x1000c844] main /tmp/rocksdb/rocksdb-rocksdb-3.2/util/bl

oom_test.cc:179
#3 /opt/at7.0/lib64/power7/libc.so.6(+0x44a8c) [0xfff9fbf4a8c] ?? ??:0
#4 /opt/at7.0/lib64/power7/libc.so.6(__libc_start_main-0x188964) [0xfff9fbf4cb

4] ?? ??:0
make: *** [check] Error 1

@zhibaodhu
Copy link
Author

I forgot to mention that my system is rhel6.5 ppc64.

@igorcanadi
Copy link
Collaborator

Could it be related to https://code.google.com/p/leveldb/issues/detail?id=237?

@iamjinlei
Copy link

good finding @igorcanadi.

@dhruba
Copy link
Contributor

dhruba commented Aug 7, 2014

Igor: Issue 237 only occurs if you copy files from ARM to x86, is it possible that it can affect unit tests too? But we should still evaluate the contributed patch and see if we should pull it in....

@zhibaodhu
Copy link
Author

On my x86_64 systems "make check" has no problem with BloomTest. But it failed EnvPosixTest.AllocateTest:

==== Test EnvPosixTest.AllocateTest
util/env_test.cc:508: failed: 204800 > 204800
#0 ./env_test() [0x4298b6] std::string::_M_data() const /opt/rh/devtools
et-2/root/usr/include/c++/4.8.2/bits/basic_string.h:293
#1 ./env_test() [0x43248e] std::string::_M_data() const /opt/rh/devtools
et-2/root/usr/include/c++/4.8.2/bits/basic_string.h:293
#2 ./env_test() [0x5177ae] rocksdb::test::RunAllTests() /tmp/rocksdb/roc
ksdb-rocksdb-3.2/util/testharness.cc:48
#3 /lib64/libc.so.6(__libc_start_main+0xfd) [0x372fc1ed1d] ?? ??:0
#4 ./env_test() [0x4220a1] _start ??:?

@zhibaodhu
Copy link
Author

On my ppc64le Ubuntu systems "make check" has no problem if it is run with LD_LIBRARY_PATH set correctly:

LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/lib/powerpc64le-linux-gnu make check

@zhibaodhu
Copy link
Author

"Make check" failed bloom_test on my rhel7 ppc64 system the same way it failed on rhel6u5 ppc64 systems:

util/bloom_test.cc:161: failed: 0.0256 <= 0.02
#0 ./bloom_test() [0x1002e7e8] ~BloomTest /tmp/rocksdb/rocksdb-rocksdb-3.2
/util/bloom_test.cc:49
#1 ./bloom_test() [0x101634e0] rocksdb::test::RunAllTests() /tmp/rocksdb/roc
ksdb-rocksdb-3.2/util/testharness.cc:59
#2 ./bloom_test() [0x1000c624] main /tmp/rocksdb/rocksdb-rocksdb-3.2/util/bl
oom_test.cc:179
#3 /opt/at7.0/lib64/power8/libc.so.6(+0x44acc) [0x3fff9b914acc] ?? ??:0
#4 /opt/at7.0/lib64/power8/libc.so.6(__libc_start_main-0x189924) [0x3fff9b914c
f4] ?? ??:0

@siying
Copy link
Contributor

siying commented Apr 6, 2015

@zhibaodhu the EnvPosixTest.AllocateTest issues was fixed a while ago. Did you have a chance to retry it?

@igorcanadi
Copy link
Collaborator

Closing this issue since it's likely fixed. Please reopen if you see any other issues.

hunterlxt pushed a commit to hunterlxt/rocksdb that referenced this issue Jul 9, 2021
I needed these changes to run `make` successfully.

See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352

Signed-off-by: Breezewish <me@breeswish.org>

Co-authored-by: Greg Weber <greg@gregweber.info>
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this issue Sep 21, 2021
luky116 pushed a commit to luky116/rocksdb that referenced this issue Jul 10, 2024
We should return Status::OK and return additional information through the bool* update_applied argument for ApplyCloudManifestDelta.

Also, now that it's possible to have one filenum showing more than once in CLOUDMANFIEST with different epochs, we should only check filenum is sorted in ascending order when loading CM from file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants