Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow PHPUnit 11 (WIP) #229

Closed
wants to merge 4 commits into from
Closed

feat: allow PHPUnit 11 (WIP) #229

wants to merge 4 commits into from

Conversation

Chris53897
Copy link

`composer require "phpunit/phpunit:11.0.1" --dry-run``

  Problem 1
    - Root composer.json requires phpunit/phpunit 11.0.1 (exact version match: 11.0.1 or 11.0.1.0), found phpunit/phpunit[11.0.1] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - phpspec/prophecy-phpunit is locked to version dev-master and an update of this package was not requested.
    - phpspec/prophecy-phpunit dev-master requires phpunit/phpunit ^9.1 || ^10.1 -> found phpunit/phpunit[9.1.0, ..., 9.6.16, 10.1.0, ..., 10.5.10] but it conflicts with your root composer.json require (11.0.1).

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately not enough, since Prophecy is stopping the upgrade too.

We need two additional, external PRs for that, one in phpspec/prophecy-phpunit (to allow PHPUnit 11), the second in phpspec/prophecy (to allow sebastian/comparator 6).

I'll try to do that ASAP, but I starting to think that I may migrate toward PHPUnit's mocks...

@Jean85 Jean85 added the bug label Feb 4, 2024
@Jean85 Jean85 added this to the 2.3 milestone Feb 4, 2024
@Jean85 Jean85 mentioned this pull request Feb 4, 2024
@Chris53897
Copy link
Author

I did a look at this repos, and there is maybe more :(
I am not sure if there are circular dependencies between "phpspec/prophecy" and "phpspec/phpspec".
That was the point i decided that this does not need to be solved today ;)

@kubawerlos
Copy link
Contributor

I starting to think that I may migrate toward PHPUnit's mocks...

If you make this decision I'd be happy to help. I already did it in PHP CS Fixer repo.

@Jean85
Copy link
Member

Jean85 commented Feb 4, 2024

Ok, I've filed phpspec/prophecy#616 and phpspec/prophecy-phpunit#59, but we need both of them to work here. I'll try to commit the requirement for phpspec/prophecy-phpunit#58 to pull this off.

If you make this decision I'd be happy to help. I already did it in PHP CS Fixer repo.

Thanks! That would be helpful: the only doubt that I have is that in that way, I would be bound to PHPUnit breaking changes, and I do not know if that would be better or worse compared to the issues I'm having with Prophecy.

@Jean85
Copy link
Member

Jean85 commented Feb 4, 2024

Closing in favor of #230, GitHub Actions are not allowing secrets to be used when the PR comes from a fork.

@Jean85 Jean85 closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants