Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHPUnit 11 #59

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Allow PHPUnit 11 #59

merged 3 commits into from
Feb 7, 2024

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 4, 2024

This PR is the only code change needed to run with PHPUnit 11, but it also requires phpspec/prophecy#616, as proved by #58.

Jean85 added a commit to facile-it/paraunit that referenced this pull request Feb 4, 2024
@Jean85
Copy link
Contributor Author

Jean85 commented Feb 6, 2024

Tests seem to fail only due to #60

[EDIT] It does not seem to be using PHPUnit 11 in CI, except for the "dev deps" job... What could be the blocker? Oh right, Prophecy didn't get a tag yet.

@stof
Copy link
Member

stof commented Feb 6, 2024

@Jean85 that's expected: the PR in prophecy has been merged, but there has not been a new release yet. So jobs running with stable dependencies cannot install a version of Prophecy supporting PHPUnit 11 yet (that's the whole point of having a job running with dev deps btw: testing those things before the release instead of only after it).

@Jean85
Copy link
Contributor Author

Jean85 commented Feb 6, 2024

Right right, I figured out the same while you were replying.

So, it's seems to work, apart from the deprecation that I already reported in #60.

@stof
Copy link
Member

stof commented Feb 6, 2024

For the deprecation, let's wait for the answer of Sebastian about the proper way to solve our case (see my comment in the issue and the corresponding issue opened in the phpunit issue tracker)

@Jean85
Copy link
Contributor Author

Jean85 commented Feb 6, 2024

@stof I've introduced the attributes, and fixed the build with a dedicated, migrated configuration.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@stof stof merged commit 50345c4 into phpspec:master Feb 7, 2024
8 checks passed
@Jean85 Jean85 deleted the allow-phpunit-11 branch February 8, 2024 08:36
@jorgsowa
Copy link

Thank you for this PR. Do you have a plan to release a new version of the package with the support for PHPUnit 11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants