Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use basic reporter #1763

Merged
merged 2 commits into from
Jan 22, 2023
Merged

test: use basic reporter #1763

merged 2 commits into from
Jan 22, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 22, 2023

closes #1635

This fixes running tests locally
The previous default reporter cleared the console log everytime when to much is going on in the console
But this results in issues with to many tests and it hangs
So this new reporter do what would be done when CI=true would be configured and will not clear the screen anymore
IMO this is even a better UX

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #1763 (132b3eb) into next (ee94f3e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1763   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      242624   242624           
  Branches     1103     1103           
=======================================
  Hits       241772   241772           
  Misses        831      831           
  Partials       21       21           

@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2023

I checked locally and the original error is no longer there on my current device.
I will try on my other devices as well later.

@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2023

I tried it on my second device as well as dev containers and am no longer able to reproduce the error described in #1635 .
(Even without the fix described in this PR)

@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2023

It's okay anyway,

@xDivisionByZerox
Copy link
Member

This is so great! I can finally run tests locally without specifying the test file ♥

@Shinigami92 Shinigami92 merged commit 5f5be20 into next Jan 22, 2023
@Shinigami92 Shinigami92 deleted the use-basic-reporter-for-tests branch January 22, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix pnpm run test run
3 participants